Update dependencies - #299
Conversation
📝 WalkthroughWalkthroughThe pull request updates package versions and CI .NET setup actions, adjusts Git text attributes, changes generator array-initializer handling, removes a generator class modifier, and aligns test analyzer references and .NET 11 reference assemblies. ChangesToolchain and generator updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.gitattributes (1)
1-2: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPreserve the existing language-specific diff/merge attributes.
This change removes
*.cs diff=csharp,*.html diff=html,*.sln merge=union, and*.csproj merge=union; unless intentional, Git will fall back to generic behavior for these files, making reviews and solution merges less reliable. Retain those rules alongside the new*.verified.csrule. (github.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.gitattributes around lines 1 - 2, Update the .gitattributes rules by retaining the existing C# and HTML diff attributes and solution/project union-merge attributes, while preserving the new *.verified.cs text, LF, and UTF-8 settings. Ensure all language-specific diff and merge behavior remains alongside the new rule..editorconfig (1)
326-326: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winScope the MA0002 suppression instead of disabling it for all tests.
MA0002 checks for explicit string comparers on collections and LINQ operations such as
Dictionary,HashSet, andDistinct; suppressing it acrosstests/**/*.cscan hide nondeterministic or culture-sensitive test setup. Fix the offending tests or narrow the suppression to the specific fixture that requires it. (github.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.editorconfig at line 326, Scope the dotnet_diagnostic.MA0002.severity suppression in .editorconfig to only the specific test fixture that requires it, or remove it after updating offending tests to provide explicit string comparers for collections and LINQ operations. Do not leave MA0002 disabled across tests/**/*.cs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.editorconfig:
- Line 326: Scope the dotnet_diagnostic.MA0002.severity suppression in
.editorconfig to only the specific test fixture that requires it, or remove it
after updating offending tests to provide explicit string comparers for
collections and LINQ operations. Do not leave MA0002 disabled across
tests/**/*.cs.
In @.gitattributes:
- Around line 1-2: Update the .gitattributes rules by retaining the existing C#
and HTML diff attributes and solution/project union-merge attributes, while
preserving the new *.verified.cs text, LF, and UTF-8 settings. Ensure all
language-specific diff and merge behavior remains alongside the new rule.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a9c98d42-3d9e-4b39-93bb-319c526a98cb
📒 Files selected for processing (9)
.editorconfig.gitattributes.github/workflows/build.yml.github/workflows/release.ymlDirectory.Packages.propssrc/Immediate.Validations.Generators/Utility.cssrc/Immediate.Validations.Generators/ValidateTargetTransformer.cstests/Immediate.Validations.Tests/Immediate.Validations.Tests.csprojtests/Immediate.Validations.Tests/Utility.cs
Summary by CodeRabbit