Skip to content

Update dependencies - #299

Merged
viceroypenguin merged 1 commit into
mainfrom
dependencies
Jul 28, 2026
Merged

Update dependencies#299
viceroypenguin merged 1 commit into
mainfrom
dependencies

Conversation

@viceroypenguin

@viceroypenguin viceroypenguin commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of array initializer validation scenarios.
  • Maintenance
    • Updated .NET tooling and analysis configurations for improved compatibility.
    • Refreshed supported framework reference assemblies and development packages.
    • Standardized line-ending and encoding handling for verified generated files.
  • Testing
    • Updated test infrastructure to support newer .NET 11 reference assemblies and analyzer versions.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request updates package versions and CI .NET setup actions, adjusts Git text attributes, changes generator array-initializer handling, removes a generator class modifier, and aligns test analyzer references and .NET 11 reference assemblies.

Changes

Toolchain and generator updates

Layer / File(s) Summary
Package and workflow alignment
Directory.Packages.props, .github/workflows/*, .gitattributes
Central package versions, .NET setup actions, and Git text attributes are updated.
Generator operation handling
src/Immediate.Validations.Generators/Utility.cs, src/Immediate.Validations.Generators/ValidateTargetTransformer.cs
Utility is no longer partial, and array initializer element values are captured without requiring a non-null pattern match.
Test framework alignment
.editorconfig, tests/Immediate.Validations.Tests/*
Analyzer suppression, target-framework-specific analyzer references, and the .NET 11 reference assembly version are updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: several dependency and package version updates across the repo.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependencies

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
.gitattributes (1)

1-2: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the existing language-specific diff/merge attributes.

This change removes *.cs diff=csharp, *.html diff=html, *.sln merge=union, and *.csproj merge=union; unless intentional, Git will fall back to generic behavior for these files, making reviews and solution merges less reliable. Retain those rules alongside the new *.verified.cs rule. (github.com)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.gitattributes around lines 1 - 2, Update the .gitattributes rules by
retaining the existing C# and HTML diff attributes and solution/project
union-merge attributes, while preserving the new *.verified.cs text, LF, and
UTF-8 settings. Ensure all language-specific diff and merge behavior remains
alongside the new rule.
.editorconfig (1)

326-326: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Scope the MA0002 suppression instead of disabling it for all tests.

MA0002 checks for explicit string comparers on collections and LINQ operations such as Dictionary, HashSet, and Distinct; suppressing it across tests/**/*.cs can hide nondeterministic or culture-sensitive test setup. Fix the offending tests or narrow the suppression to the specific fixture that requires it. (github.com)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.editorconfig at line 326, Scope the dotnet_diagnostic.MA0002.severity
suppression in .editorconfig to only the specific test fixture that requires it,
or remove it after updating offending tests to provide explicit string comparers
for collections and LINQ operations. Do not leave MA0002 disabled across
tests/**/*.cs.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.editorconfig:
- Line 326: Scope the dotnet_diagnostic.MA0002.severity suppression in
.editorconfig to only the specific test fixture that requires it, or remove it
after updating offending tests to provide explicit string comparers for
collections and LINQ operations. Do not leave MA0002 disabled across
tests/**/*.cs.

In @.gitattributes:
- Around line 1-2: Update the .gitattributes rules by retaining the existing C#
and HTML diff attributes and solution/project union-merge attributes, while
preserving the new *.verified.cs text, LF, and UTF-8 settings. Ensure all
language-specific diff and merge behavior remains alongside the new rule.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a9c98d42-3d9e-4b39-93bb-319c526a98cb

📥 Commits

Reviewing files that changed from the base of the PR and between 4c2785e and 3fb7217.

📒 Files selected for processing (9)
  • .editorconfig
  • .gitattributes
  • .github/workflows/build.yml
  • .github/workflows/release.yml
  • Directory.Packages.props
  • src/Immediate.Validations.Generators/Utility.cs
  • src/Immediate.Validations.Generators/ValidateTargetTransformer.cs
  • tests/Immediate.Validations.Tests/Immediate.Validations.Tests.csproj
  • tests/Immediate.Validations.Tests/Utility.cs

@viceroypenguin
viceroypenguin merged commit 713d005 into main Jul 28, 2026
3 checks passed
@viceroypenguin
viceroypenguin deleted the dependencies branch July 28, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant