Skip to content

Add NRT markers - #302

Merged
viceroypenguin merged 2 commits into
mainfrom
nrt
Aug 2, 2026
Merged

Add NRT markers#302
viceroypenguin merged 2 commits into
mainfrom
nrt

Conversation

@viceroypenguin

@viceroypenguin viceroypenguin commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Improvements
    • Enhanced nullability annotations for validation methods improve compile-time analysis and developer guidance.
    • Validation helpers now clearly indicate that invalid inputs do not return.
    • Runtime validation behavior remains unchanged.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: adaf6288-e686-48f2-9f88-8ccd9303bee2

📥 Commits

Reviewing files that changed from the base of the PR and between bbea01a and a6e91e4.

📒 Files selected for processing (1)
  • src/Immediate.Validations.Shared/ValidationException.cs

📝 Walkthrough

Walkthrough

The change updates three generic ThrowIfInvalid overloads for nullable-flow analysis. It adds [NotNull] annotations, updates the message-factory parameter type, suppresses related compiler warnings, and marks private exception helpers with [DoesNotReturn].

Changes

Validation contracts

Layer / File(s) Summary
Annotate validation overloads
src/Immediate.Validations.Shared/ValidationException.cs
The three generic ThrowIfInvalid overloads now accept [NotNull] T?. The message factory accepts Func<T?, string>. Compiler-warning state is managed around the methods, and private exception helpers use [DoesNotReturn].

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the addition of nullable reference type annotations to the validation APIs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nrt

Comment @coderabbitai help to get the list of available commands.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30726282654

Coverage remained the same at 83.852%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 2217
Covered Lines: 1859
Line Coverage: 83.85%
Coverage Strength: 3.35 hits per line

💛 - Coveralls

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/Immediate.Validations.Shared/ValidationException.cs`:
- Line 59: Add explicit null guards to all three ThrowIfInvalid overloads in
ValidationException so null inputs always fail independently of validator
implementations; alternatively, if nullable inputs are intentionally supported,
remove the [NotNull] annotations and preserve that contract consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7019856c-e54e-4d07-a0cd-99d432ce5a69

📥 Commits

Reviewing files that changed from the base of the PR and between e391307 and bbea01a.

📒 Files selected for processing (1)
  • src/Immediate.Validations.Shared/ValidationException.cs

Comment thread src/Immediate.Validations.Shared/ValidationException.cs Outdated
@viceroypenguin
viceroypenguin merged commit 55baca5 into main Aug 2, 2026
3 checks passed
@viceroypenguin
viceroypenguin deleted the nrt branch August 2, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants