Repository navigation
ci: give the release build's test run CI's dependencies - #1632
Merged
Merged
Conversation
The v0.44.0 Release run failed all three build jobs in the suite, not in the runtime: the dependency-gated sections now FAIL rather than skip when a dependency is absent, and the release job runs on bare hosted runners while CI tests in the dev image (Linux) or after its toolchain step (macOS). - Linux: $TMPDIR unset, so two diagnostics redirected to /eigs-host-frame.err and /eigs-sandbox-1426.err (#1624), and the strict-shape backend controls found no libSDL2. - macOS: no `timeout`, so all nine gfx example checks exited 127 and the gfx sanitizer gate refused to run. Install the dev image's runtime test packages (Linux) and ci.yml's macOS toolchain step, both AFTER the builds so the shipped binaries and the glibc floor do not change, and give the suite a TMPDIR. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.44.0 Release run (37291483115) created the tag but failed all three build jobs inside the test suite. None of the failures is in the runtime; each is a dependency CI has and the bare release runners lack, and the suite's dependency-gated sections now fail rather than skip:
TMPDIRis unset, sorun_all_tests.shredirected two diagnostics to/eigs-host-frame.errand/eigs-sandbox-1426.err(Permission denied, Full suite assumes TMPDIR is set in two diagnostic redirections #1624); and the strict-shape backend controls found no libSDL2.timeout, so all nine gfx example checks exited 127 and the gfx sanitizer gate refused to run.This installs the dev image's runtime test packages on Linux and mirrors
ci.yml's macOS toolchain step (coreutils, upstream LLVM for the gfx LSan runtime). Both run AFTER the builds, so the shipped binaries and the Linux glibc floor are unchanged. The test step getsTMPDIR=${{ runner.temp }}; #1624 (fixing the runner itself) stays open.After merge: delete the v0.44.0 tag (no GitHub release was created) and re-dispatch Release.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF