Repository navigation
docs: record owner decisions in PRINCIPLES; contract bool==num exception - #1671
Conversation
…, small machine); contract bool==num exception Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a6bd7f51c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Buffers / text-builders: by contents. | ||
| - Functions, builtins: by identity. | ||
| - Mixed types: `"3" == 3` is `false`, never an error. | ||
| - The one exception: `bool` vs number raises at any depth, e.g. `true == 1` and `[true] == [1]` (#1637). A bool |
There was a problem hiding this comment.
When an earlier element differs—for example, [0, true] == [1, 1]—values_equal_impl returns false before reaching the bool/number pair, as docs/SPEC.md already specifies. The unqualified claim that bool versus number “raises at any depth” therefore overstates the enforced contract; clarify that it raises only when the structural comparison reaches that pair.
Useful? React with 👍 / 👎.
1 participant
This records the owner's decisions of 2026-10-07 as the source of user intent (see #1670):
boolvs number raises at any depth. That line had drifted and is now corrected.🤖 Generated with Claude Code
https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF