Repository navigation
Buffer and host builtins onto the slot API (#1665 arm D B6) - #1718
Merged
Merged
Conversation
Batch B6 of the arm D step-2 design: builtins_buf.c and builtins_host.c leave the legacy borrow API and join the migrated-files gate (Codex Cloud builder). strict_shape_contract.py's candidate discovery also matches list_sort( (widens the audited population; it is unchanged at 190). Local gates on top of B5: Ir vs B5 flat; tape identical; jit-smoke; jit_diff (257); release 4220/4221, full ASan (detect_leaks=1) 4211/4212 with leak tally 0 -- the one failure in each is the pre-existing [99d] (#1708); rehearsal adds the pre-existing [70d] (#1709). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1665: batch B6 of the arm D step-2 design.
builtins_buf.candbuiltins_host.cleave the legacy borrow API and join the migrated-files gate. Storage staysValue**.strict_shape_contract.py's candidate discovery now also matcheslist_sort(. This can only widen the audited population, which stays at 190.Gates (run locally on top of B5)
make httpjit-smokejit_diffdetect_leaks=1[70d](#1709)The one failure in the release and ASan suites is the pre-existing
[99d](#1708).Built by Codex Cloud; gated locally.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF