Repository navigation
ci: nightly's Valgrind job uses the shared install action (#1942) - #1959
Merged
Merged
Conversation
See the PR for the evidence (each surviving implementation was compared with both copies on every input either copy handled). Based on a Codex Cloud draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1942.
Evidence (the Codex Cloud draft's report, reviewed):
Result
The
nightly.ymlvalgrind-fulljob now invokes the same local compositeaction as both Valgrind lanes in
ci.yml. The two environment variables thatno committed caller set were removed rather than preserving an unrepeatable
test interface.
Old/new input inventory and differential
The old nightly step consumed these states: Valgrind already present; present
but not runnable; the initial install succeeding or installing an unrunnable
binary; refresh/install attempt 1, 2, or 3 succeeding or installing an
unrunnable binary; and all four installs failing. I modeled all eleven states
from the two shell control flows and ran the model for both implementations.
The old and shared implementations agree on outcome, install count, and update
count in every state:
The comparison did find the already-reported command-level disagreement. The
old nightly copy installed only
valgrind, refreshed the image's configuredsources, and did not retain packages. The shared implementation installs
valgrind libc6-dbgwith--no-install-recommends, refreshes explicit Ubuntusources, and retains the archives. The shared answer is correct: its comment
records why Noble needs
libc6-dbgfor Memcheck startup, and the compositeaction deliberately owns restoration and publication of its archive cache.
Selecting it also makes nightly exercise exactly the implementation exercised
by the PR lanes instead of silently preserving the known divergence.
The differential was run with:
It printed
diff=nonefor every row above and printed the command disagreementseparately. Static checks also show that the diagnostic now has one owner and
the dead environment knobs have none:
Gate plant
After a green workflow check, I outdented the new
useskey by two spaces.bash tools/workflow_yaml_check.shreturned 1 withworkflow-yaml: FAILand aYAML block-collection parse error. Restoring the workflow returned the same
command to
workflow-yaml: OK;bash tools/ci_tier_check.shwas green beforeand after the plant.
Checks
bash tools/workflow_yaml_check.sh: green (workflow-yaml: OK, 9 files).bash tools/ci_tier_check.sh: green, including its own self-test.bash tools/precheck.sh: 15 checks passed, three binary-dependent checksskipped because no EigenScript binary was built, and the changelog check
could not run because this shallow checkout has no
originremote ormerge-base. The applicable workflow and CI-tier checks passed within it.
git diff --check: green.Hosted nightly
🤖 Generated with Claude Code
https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF