Repository navigation
docs-claims: one call-claim vocabulary and matcher for both doc sets (#1944) - #1961
Merged
Merged
Conversation
…1944) See the PR for the evidence (each surviving implementation was compared with both copies on every input either copy handled). Based on a Codex Cloud draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1944.
Evidence (the Codex Cloud draft's report, reviewed):
Implementation and dead-code disposition
name_vocabulary()now parses the typedbuiltin,extension, andlibrows from
--api, then adds the predicate, lexer, and reserved language callforms once.
names()applies the singleCALL_CLAIMmatcher and that same setto both document sets. The three contract pages are therefore no longer walked
by a second implementation. The source-comment/compiler comparisons remain a
separate input shape, but consume the same vocabulary.
The
register_builtinsscrape did not participate in any verdict. It and the"direct registration row(s)" summary were removed rather than pretending that
direct rows describe the full API:
--apiis generated from the live runtimeenvironment and includes delegated extension and host registrations.
Old/new input enumeration and differential
I enumerated every match as
(file, line, name)over the exact two old documentsets with a Python script using the old regexes and the new regex:
NAMESset (README, llms, CLAUDE, ARCHITECTURE, BUILTINS,CONCURRENCY, ROADMAP, CI): old 426, new 427.
difference.
docs/llms.txt:240,buffer ofat end of a line.The new/contract answer is right: Markdown prose continues the invocation on
the next line, and end-of-line is whitespace rather than the end of the call
claim. This was the issue's identified matcher discrepancy, so it is made
explicit rather than silently retaining the under-match.
Applying the stricter common vocabulary exposed two intentional non-global
callees:
name.fis a runtime namespace member andris locally bound byinline
local r is observe. The shared implementation now states thosesemantics: it collects inline local bindings and does not misrepresent a
qualified runtime member as a global
--apiname. These preserve the oldcontract gate's answers and apply consistently to both sets.
Required planted red/green proof
I appended
`planted_stale_1944 of null`todocs/PREDICATES.mdand ranbash tools/docs_claims_check.sh. It exited 1 with:After restoring the file, the identical command exited 0 with:
The permanent selftest plants an end-of-line stale claim in
docs/PREDICATES.md, proving that this exact shared matcher path remains red.🤖 Generated with Claude Code
https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF