Skip to content

docs-claims: one call-claim vocabulary and matcher for both doc sets (#1944) - #1961

Merged
InauguralPhysicist merged 1 commit into
mainfrom
docs-claims-one-vocab-1944
Oct 24, 2026
Merged

InauguralPhysicist merged 1 commit into
mainfrom
docs-claims-one-vocab-1944

Conversation

@InauguralPhysicist

Copy link
Copy Markdown
Collaborator

Closes #1944.

Evidence (the Codex Cloud draft's report, reviewed):

Implementation and dead-code disposition

name_vocabulary() now parses the typed builtin, extension, and lib
rows from --api, then adds the predicate, lexer, and reserved language call
forms once. names() applies the single CALL_CLAIM matcher and that same set
to both document sets. The three contract pages are therefore no longer walked
by a second implementation. The source-comment/compiler comparisons remain a
separate input shape, but consume the same vocabulary.

The register_builtins scrape did not participate in any verdict. It and the
"direct registration row(s)" summary were removed rather than pretending that
direct rows describe the full API: --api is generated from the live runtime
environment and includes delegated extension and host registrations.

Old/new input enumeration and differential

I enumerated every match as (file, line, name) over the exact two old document
sets with a Python script using the old regexes and the new regex:

  • Front-door NAMES set (README, llms, CLAUDE, ARCHITECTURE, BUILTINS,
    CONCURRENCY, ROADMAP, CI): old 426, new 427.
  • Contract set (SPEC, PREDICATES, OBSERVER): old 147, new 147; empty symmetric
    difference.
  • The sole disagreement is docs/llms.txt:240, buffer of at end of a line.
    The new/contract answer is right: Markdown prose continues the invocation on
    the next line, and end-of-line is whitespace rather than the end of the call
    claim. This was the issue's identified matcher discrepancy, so it is made
    explicit rather than silently retaining the under-match.
  • Both old gates and the new gate produce no verdict on the unmodified tree.
    Applying the stricter common vocabulary exposed two intentional non-global
    callees: name.f is a runtime namespace member and r is locally bound by
    inline local r is observe. The shared implementation now states those
    semantics: it collects inline local bindings and does not misrepresent a
    qualified runtime member as a global --api name. These preserve the old
    contract gate's answers and apply consistently to both sets.

Required planted red/green proof

I appended `planted_stale_1944 of null` to docs/PREDICATES.md and ran
bash tools/docs_claims_check.sh. It exited 1 with:

RED: docs/PREDICATES.md:963 calls planted_stale_1944 of, absent from --api and local definitions
docs-claims: FAILED (1 reference error(s))

After restoring the file, the identical command exited 0 with:

docs-claims: OK — PATHS 262, FLAGS 47, MAKE TARGETS 52, NAMES 427, DOC ENROLMENT 12

The permanent selftest plants an end-of-line stale claim in
docs/PREDICATES.md, proving that this exact shared matcher path remains red.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF

…1944)

See the PR for the evidence (each surviving implementation was compared with
both copies on every input either copy handled).

Based on a Codex Cloud draft.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
@InauguralPhysicist InauguralPhysicist added the area:lint-tooling Subsystem: lint-tooling label Oct 24, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-24T19:23:41.969338Z e6d5c29 PR opened
🔒 Security Review ✅ Completed 2026-10-24T19:26:21.525125Z e6d5c29 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codspeed

codspeed Bot commented Oct 24, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 13 untouched benchmarks


Comparing docs-claims-one-vocab-1944 (e6d5c29) with main (8316aeb)

Open in CodSpeed

@InauguralPhysicist
InauguralPhysicist added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit a63824c Oct 24, 2026
33 checks passed
@InauguralPhysicist
InauguralPhysicist deleted the docs-claims-one-vocab-1944 branch October 24, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:lint-tooling Subsystem: lint-tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs_claims_check: stale_builtin_calls (#1747) re-implements the NAMES vocabulary, and its register_builtins set reaches no verdict

1 participant