Repository navigation
Prepare for EigenScript's boolean type (EigenScript#1637) - #66
Merged
Merged
Conversation
Under EigenScript#1637 comparisons, file_exists and gfx_open return a bool, and `bool == num` raises. Each site now tests truthiness, which behaves identically on v0.44.0 (1/0) and on the bool-typed runtime. - src/game.eigs:477,493 `needs_retarget == 1` -> `needs_retarget` (bound to `pred.wander_timer <= 0`; every test died here) - test_pacing.eigs:11 check helper `ok == 1` -> `ok` (every caller passes a comparison) - tidepool.eigs:147, test_gfx.eigs:4 `result == 0` (gfx_open) -> `not result` - src/game.eigs:1520, src/neural.eigs:513 `file_exists of X == 0` -> `not (file_exists of X)` - train.eigs:512,516 `(file_exists of ..) == 1` -> `(file_exists of ..)` Before: make test failed 4 of its checks on the bool binary (PR #1647, 79e800aa), at src/game.eigs:477 and test_pacing.eigs:11. After: make lint and make test pass on v0.44.0 and on the bool binary with byte-identical output. Launch witness (xvfb-run, tidepool.eigs): the bool binary died at tidepool.eigs:147 before and now reaches the same point v0.44.0 reaches. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for EigenScript's boolean type (EigenScript#1637)
Under EigenScript#1637 comparisons, file_exists and gfx_open return a
bool, and
bool == numraises. Each site now tests truthiness, whichbehaves identically on v0.44.0 (1/0) and on the bool-typed runtime.
needs_retarget == 1->needs_retarget(bound to
pred.wander_timer <= 0; every test died here)ok == 1->ok(every callerpasses a comparison)
result == 0(gfx_open) ->not resultfile_exists of X == 0->not (file_exists of X)(file_exists of ..) == 1->(file_exists of ..)Before: make test failed 4 of its checks on the bool binary (PR #1647,
79e800aa), at src/game.eigs:477 and test_pacing.eigs:11. After:
make lint and make test pass on v0.44.0 and on the bool binary with
byte-identical output. Launch witness (xvfb-run, tidepool.eigs): the
bool binary died at tidepool.eigs:147 before and now reaches the same
point v0.44.0 reaches.
Claude-Session: https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF
Prepares this repo for the boolean type in EigenScript#1637 (PR EigenScript#1647). Every edit is dual-compatible: this repo's real CI command was run on both the v0.44.0 release binary and the PR#1647 binary, with matching results except for the bump-phase golden items listed in EigenScript#1637's consumer report. This PR lands on the current v0.44.0 pin; the golden/C-API changes land with the later pin bump.
🤖 Generated with Claude Code
https://claude.ai/code/session_01KC99CmwatKssQYggkBCgwF