Repository navigation
Print the computed solver vectors on both list and buffer runtimes - #45
Merged
Merged
Conversation
Materialize a display list for Jacobi, Gauss-Seidel and PageRank, preserving the numerical solver results and buffer allocation. EigenScript#1093 (f8745782) intentionally changed scalar zeros to numeric buffers. Closes #42. Validation: lab 3/3 programs and all three numeric vector rows on v0.43 and runtime candidate1c57a1d0; lint17/17 on both. Baseline candidate lab red; all3 old-display mutations red; 6 wrong-component controls red; 2 actual-output positive controls and exact restored lab green. Independent source review found no blockers.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Jacobi, Gauss-Seidel and PageRank demos now print every computed vector component on both the current pin and the upcoming runtime. The solvers retain their original containers and arithmetic. Tests check all three finite components on each named output row instead of matching a number anywhere in the transcript.
The upstream type change is intentional: EigenScript#1093, commit f8745782, changed scalar
zerosfrom list to buffer. Its SPEC documents the breaking change.Validation: all3 lab programs and all3 vector rows pass on v0.43.0 (a6c50fb) and candidate1c57a1d0; lint17/17 on both. Baseline candidate lab failed on the buffer placeholder. Each of3 reverted display sites fails its named assertion;6 wrong-middle-component controls fail;2 actual-output controls pass; exact restored lab passes. Independent source review found no blockers. Full pinned CI remains the merge gate.
Closes #42.