Repository navigation
Automate EigenScript formula bump pull requests - #13
Conversation
Check the latest stable release daily or on manual dispatch, compute the checksum from the downloaded tag archive, and open an idempotent same-tap bump PR. A reserved manual validation base supports a live end-to-end check without changing main. Document approval of token-created PR workflows. Validation: 20/20 mocked controls; 7/7 original fault plants and 2/2 body-file plants detected; independent source review and independent20/20 controls green. Formula remains0.43.0. Live Actions/bump-PR/brew validation remains pending and is required before closing EigenScript#1297. Refs InauguralSystems/EigenScript#1297
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
InauguralPhysicist
left a comment
There was a problem hiding this comment.
Independent source review and regrade of the final body-file delta found no P0/P1; both the builder and critic observed20/20 mocked controls. Formula bytes remain unchanged at0.43.0. Real scheduled/manual Actions behavior and a generated formula PR with completed brew test-bot are the remaining acceptance steps; this PR installs the workflow needed for that live proof.
Reviewed commit: dd679405942e17dd6870d2b1c5d1824c8ed86851
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd67940594
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: python3 -B scripts/test_bump_formula.py | ||
| - name: Open a formula bump PR when behind | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
Use a credential that triggers the formula checks
Passing the workflow's GITHUB_TOKEN to gh pr create prevents the resulting pull_request event from starting another workflow run: GitHub documents that events triggered by this token do not create workflow runs, except for workflow_dispatch and repository_dispatch (official documentation). Consequently, automated bump PRs never execute the formula checks in .github/workflows/tests.yml, whose formula step is restricted to github.event_name == 'pull_request'; there will be no pending run to approve as the README suggests. Use a GitHub App/PAT credential that can trigger workflows, or explicitly dispatch a validation workflow that actually runs the formula checks.
Useful? React with 👍 / 👎.
The tap currently needs a manual formula edit for every EigenScript release. A daily or manually dispatched workflow now reads the latest stable release, computes the checksum from its downloaded tag archive, and opens a bump PR when the selected formula is behind. Repeated runs reuse an open bump PR; the current formula remains0.43.0.
Uses the tap’s GITHUB_TOKEN. The runbook explains approval of generated PR workflows and provides an isolated validation-base procedure that leaves main unchanged.
Validation:20/20 mocked functional controls;9/9 targeted fault plants detected across the original and body-file corrections; independent source review and repeated20/20 controls. Live Actions and real bump-PR/brew checks remain pending.
Refs InauguralSystems/EigenScript#1297. Companion documentation repair: InauguralSystems/EigenScript#1545.