Skip to content

Fix PR review follow-ups#16

Merged
wauputr4 merged 1 commit into
mainfrom
codex/fix-pr-review-followups
Jun 14, 2026
Merged

Fix PR review follow-ups#16
wauputr4 merged 1 commit into
mainfrom
codex/fix-pr-review-followups

Conversation

@wauputr4

Copy link
Copy Markdown
Member

Summary

  • sanitize rendered README HTML before injecting it into project detail pages
  • rewrite repo-relative README links/images to GitHub/raw URLs
  • normalize scheme-less project homepage URLs before rendering buttons/links
  • resolve relative blog thumbnail frontmatter to raw GitHub URLs during sync

Verification

  • rtk npm run build
  • ASTRO_BASE=/indopensource.org npm run build

Context: PR #15 was already merged, so these are follow-up fixes for the Codex review findings.

@wauputr4 wauputr4 merged commit d90b77f into main Jun 14, 2026
1 check passed
@wauputr4 wauputr4 deleted the codex/fix-pr-review-followups branch June 14, 2026 00:57

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3469b408ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (!value || value.startsWith('#')) return value;

try {
const url = new URL(value, baseUrl);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve repo-root README paths

When a README uses GitHub's supported repo-root-relative syntax such as [docs](/docs/guide.md) or ![logo](/assets/logo.png), resolving it with new URL(value, data.html_url/download_url) treats the leading slash as the domain root, producing https://github.com/docs/guide.md or https://raw.githubusercontent.com/assets/logo.png and dropping the owner/repo/branch. This breaks those README links and images on the project detail page; root-relative paths need to be resolved against the repository root URL rather than the file URL.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant