Make project cards fully clickable#17
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 710c90bd89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ac2d27c22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c34db6556f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4922fcdf5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| > | ||
| <a class="absolute inset-0 z-0 rounded-lg" href={detailUrl} aria-label={`Buka detail ${project.fullName}`}></a> | ||
| <a | ||
| class="absolute inset-0 z-0 rounded-lg focus:outline-none focus-visible:ring-2 focus-visible:ring-brand/40" |
There was a problem hiding this comment.
On project cards with descriptions, topics, or stats, this full-card anchor remains at z-0 while those visible content blocks are relative z-10 siblings. Clicks on those non-link text/badge areas hit the z-10 elements and never bubble to this anchor, so the new card-level pointer styling still leaves most of the card body non-navigable; only exposed gaps or explicit child anchors work.
Useful? React with 👍 / 👎.
|
|
||
| try { | ||
| const url = new URL(value, baseUrl); | ||
| const url = new URL(value, value.startsWith('/') ? rootBaseUrl : baseUrl); |
There was a problem hiding this comment.
When a README contains a root-relative link or image such as /docs/guide.md or /assets/logo.png, this still passes the leading slash to new URL. A leading slash resets to the origin, so resolving against https://github.com/owner/repo/blob/main/ produces https://github.com/docs/guide.md (and raw assets become https://raw.githubusercontent.com/assets/...) instead of staying under the repository; strip the leading slash before resolving against the computed repo root.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification