Add permission checks and upload limit config fix#109
Open
tdat314 wants to merge 4 commits into
Open
Conversation
Document access control considerations and recommendations for implementing role-based permissions and team scopes.
Collaborator
Author
|
I added one additional small backend cleanup after the initial route hardening: the upload middleware now imports attachment limits from the existing group config file. I also added the access-control docs folder/notes as a place to collect the broader team/group-scope plan separately from implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a few small access-control/security-related cleanup items:
User.can('edit data')middleware to destructive incident/group routes.Rationale
I started with small, reviewable changes rather than jumping directly into the broader access-control implementation. The route changes use the existing authorization pattern already present elsewhere in the codebase. The upload limit change keeps the middleware aligned with the same config source used by the model/routes/controllers.
Scope
This PR does not implement the full team/group-scoped access-control model. It is intended as an initial hardening and planning step.
Potential impact
Users or integrations without
edit datapermission will no longer be able to clear tags or delete incident/group records through these routes.verification
User.can('edit data').backend/config/models/groupConfigs.js.