Ifx fix empty feature board filter - #25
Merged
Merged
Conversation
… opted in A direct push to a branch with zero feature_board=true boards (e.g. control-main today) previously filtered ALL_BOARD_DATA down to an empty array, causing build-board to produce zero binaries and package-core to crash with a confusing 'tar: Cannot open: No such file or directory' instead of a clear error. Only apply the feature-board filter if it leaves at least one board, so branches with no board opted in yet keep building/packaging their full board set exactly as before this mechanism existed.
Previously only direct pushes were limited to a board family's own feature_board boards; PRs always ran the full board matrix as a pre-merge safety net. Per request, apply the same filtering to PRs as well, so both events only build/test the branch's own boards (still falling back to the full set if none are opted in). Note: this trades away full-matrix pre-merge validation on PRs against edge-main/control-main - a PR touching shared CI/build logic will no longer be checked against unrelated boards (giga, portenta, etc.) before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Description
Extends the feature_board filtering (previously push-only) to also
apply to pull_request events, so both push and PR builds/tests only
cover a branch's own opted-in boards (e.g. kit_pse84_ai on edge-main),
falling back to the full board set if none are opted in yet (e.g.
control-main today).
Trade-off: PRs against edge-main/control-main no longer validate the
full upstream board matrix before merge - only the branch's own
feature board(s). A PR changing shared CI/build logic won't be
automatically checked against unrelated boards (giga, portenta, etc.)
in this pipeline anymore.