fix(e2e): rework kubernetes gateway connectivity test for the PAM accounts model#302
Draft
claude[bot] wants to merge 2 commits into
Draft
fix(e2e): rework kubernetes gateway connectivity test for the PAM accounts model#302claude[bot] wants to merge 2 commits into
claude[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Sheen · Slack thread
Before / After
Before:
TestGateway_RelayGatewayConnectivityfails in CI — itskubernetesandredissubtests error because they create PAM resources via the removedPOST /api/v1/pam/resources/{type}routes, which now return HTTP 404.After: the
kubernetessubtest is reworked to the revamped PAM account model and exercises gateway relay connectivity again; theredissubtest is skipped until redis PAM is re-added to the backend.Why
The relay e2e job builds the backend from
infisical/infisical's latestmain(no version pin), so the generated e2e client (e2e/packages/client/client.gen.go) has drifted. The backend replaced the flatresources/{type}PAM creation with a folder + template + account model under/api/v1/pam/accounts/{type}, and does not yet implementredisas a PAM account type.Changes
e2e/relay/gateway_test.go— thekubernetessubtest now creates a PAM folder, akubernetesaccount template, and a kubernetes account (pointed at the mock server), then asserts the gateway proxied the/versionprobe. Theredissubtest is skipped with aTODOuntil redis PAM lands on the backend.e2e/openapi-cfg.yaml— whitelisted thecreatePamFolder,createPamAccountTemplate, andcreateKubernetesPamAccountoperations.e2e/packages/client/client.gen.go— added client methods for those three operations to match the current backend routes. These were hand-added to match the whitelist; a fullmake generate-codeagainst a current backend should reproduce them.Notes
TestGateway_RelayGatewayConnectivity/redisremains skipped; re-enable once redis PAM is implemented as an account type.