Repository navigation
chore: remove go controller - #42
Merged
InftyAI-Agent merged 1 commit intoOct 17, 2026
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Member
Author
|
/lgtm |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
InftyAI-Agent
added
needs-triage
InftyAI-Agent
approved these changes
Oct 17, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
InftyAI-Agent
pushed a commit
that referenced
this pull request
Oct 17, 2026
The Ed25519 JWT verifier was only reachable through the sandd-controller binary and FFI removed in #42; the Python Server never enabled it. Authz is expected to move to Keycloak, whose tokens need different verification, so drop the verifier, the jsonwebtoken dependency and the daemon's SANDD_TOKEN bearer header rather than keep dead code. Empty daemon ids are still refused. Signed-off-by: kerthcet <kerthcet@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
InftyAI-Agent
pushed a commit
that referenced
this pull request
Oct 17, 2026
* docs: add an end-to-end Quick Start, drop `make install` - `make install` was advertised in `make help`, the README and the Rust-import error but never existed. Drop it rather than add it: from source the package is just `pip install .`, and in a checkout `make dev` is the fix. - README: a Quick Start that builds both halves and runs a command on one machine, then Installation, then Usage (direct and tunnel mode). - Call the Python side the "server" everywhere, matching `Server` and `--server-url`; there is no separate controller program since #42. - Fix the install.sh version-pin example (v0.1.0 does not exist). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: kerthcet <kerthcet@gmail.com> * release: v0.2.0 Bump protocol, server, daemon and the Python package to 0.2.0, along with the sandd-protocol dependency pin and Cargo.lock. Point the docs and the release Dockerfiles at v0.2.0. Their defaults were broken: Dockerfile.daemon-tunnel-release pinned v0.1.0, which was never released, and Dockerfile.server-tunnel-release pinned PyPI 0.0.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: kerthcet <kerthcet@gmail.com> --------- Signed-off-by: kerthcet <kerthcet@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?