Fix walloc.d#26
Merged
Merged
Conversation
Contributor
Author
|
Requesting review. |
Member
|
LGTM, however can you verify to me that no LLM/AI Agent was used in this PR? |
Member
|
Confirmed in DMs, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several issues (including some crippling ones) with the
wallocport.get_large_objectwas done incorrectly, causing the pointer arithmetic to be wrong leading to corruption duringfree(caught be later assertions).realloc(not part of original port) had the old vs. new size comparison invertedget_alloc_size(used byrealloc; not original) logic appeared incorrect for small allocations (comparinggranulesinstead of originalkindagainst thechunk_kindenum). Unclear how big of an issue it was.