nix: migrate fetchPnpmDeps#166
Conversation
|
Could you do it for all platforms anyway? If it breaks something can revert |
I am still new to |
|
Ah, @ojsef39, @frostplexx, @xaiyadev |
|
You can get the hash on linux too. Also: you could just change the fetcherversion, then push it and the pipeline will update the hash itself |
|
The same treatment is needed for Darwin too. Although I think you need macOS to generate its pnpm hash? I can open a separate PR that applies the same change to Darwin if @Desoroxxx is unable to do it :) |
How? I tried looking but haven't found anything like that or at least it wasn't really clear, I am fine with you pointing to a doc page.
Oh well, that simplifies things lol |
|
If the pipeline does update the hash it should just work for both now |
|
Happy to merge this once it's been resolved. I don't use nix so can't help much here 💜 |
|
LGTM then |
|
Good to merge? |
|
Is there a way to a run a test pipeline kn this branch? Oterwise LGTM |
|
Someone should do a seperate pr to add a workflow to run the build and tests on pr changes. Otherwise it won't run atm. I think technically @Desoroxxx could try manually run on their branch but I wouldn't reccomend it over the solution above. |
This fixes a warning see: NixOS/nixpkgs#494184
Did not do it for Darwin as I do not have access to that platform.