Skip to content

nix: migrate fetchPnpmDeps#166

Open
Desoroxxx wants to merge 2 commits into
Inrixia:masterfrom
Desoroxxx:master
Open

nix: migrate fetchPnpmDeps#166
Desoroxxx wants to merge 2 commits into
Inrixia:masterfrom
Desoroxxx:master

Conversation

@Desoroxxx
Copy link
Copy Markdown
Contributor

@Desoroxxx Desoroxxx commented May 11, 2026

This fixes a warning see: NixOS/nixpkgs#494184

Did not do it for Darwin as I do not have access to that platform.

@Inrixia
Copy link
Copy Markdown
Owner

Inrixia commented May 11, 2026

Could you do it for all platforms anyway? If it breaks something can revert

@Desoroxxx
Copy link
Copy Markdown
Contributor Author

Could you do it for all platforms anyway? If it breaks something can revert

I am still new to nix so I might be completely wrong here, but as far as I know there is no real way for me to actually do it, I won't be able to get the real hash and it will simply fail.

@Inrixia
Copy link
Copy Markdown
Owner

Inrixia commented May 13, 2026

Ah, @ojsef39, @frostplexx, @xaiyadev

@xaiyadev
Copy link
Copy Markdown
Contributor

xaiyadev commented May 13, 2026

You can get the hash on linux too.
If nobody touches this until this evening I will fix it up ^^

Also: you could just change the fetcherversion, then push it and the pipeline will update the hash itself

@frostplexx
Copy link
Copy Markdown
Contributor

The same treatment is needed for Darwin too. Although I think you need macOS to generate its pnpm hash?

I can open a separate PR that applies the same change to Darwin if @Desoroxxx is unable to do it :)

@Desoroxxx
Copy link
Copy Markdown
Contributor Author

You can get the hash on linux too. If nobody touches this until this evening I will fix it up ^^

How? I tried looking but haven't found anything like that or at least it wasn't really clear, I am fine with you pointing to a doc page.

Also: you could just change the fetcherversion, then push it and the pipeline will update the hash itself

Oh well, that simplifies things lol

@Desoroxxx
Copy link
Copy Markdown
Contributor Author

If the pipeline does update the hash it should just work for both now

@Desoroxxx Desoroxxx changed the title nix: migrate fetchPnpmDeps (Linux) nix: migrate fetchPnpmDeps May 13, 2026
@Inrixia
Copy link
Copy Markdown
Owner

Inrixia commented May 14, 2026

Happy to merge this once it's been resolved. I don't use nix so can't help much here 💜

@frostplexx
Copy link
Copy Markdown
Contributor

LGTM then

@Inrixia
Copy link
Copy Markdown
Owner

Inrixia commented May 14, 2026

Good to merge?

@xaiyadev
Copy link
Copy Markdown
Contributor

Is there a way to a run a test pipeline kn this branch?
Not really familiar with github actions but I know this is possible on bitbucket, could we maybe try that first?

Oterwise LGTM

@Inrixia
Copy link
Copy Markdown
Owner

Inrixia commented May 14, 2026

Someone should do a seperate pr to add a workflow to run the build and tests on pr changes.

Otherwise it won't run atm.

I think technically @Desoroxxx could try manually run on their branch but I wouldn't reccomend it over the solution above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants