Skip to content

STYLE: Replace UI with IT as index type for LevelSetNode VectorContainer #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
N-Dekker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

STYLE: Replace UI with IT as index type for LevelSetNode VectorContainer #6803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/Filtering/FastMarching/include/itkLevelSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class LevelSetTypeDefault
using NodeType = LevelSetNode<PixelType, Self::SetDimension>;

/** NodeContainer type alias support */
using NodeContainer = VectorContainer<unsigned int, NodeType>;
using NodeContainer = VectorContainer<NodeType>;

/** NodeContainerPointer type alias support */
using NodeContainerPointer = typename NodeContainer::Pointer;
Expand Down
2 changes: 1 addition & 1 deletion Modules/Filtering/FastMarching/wrapping/ITKFastMarchingBase.wrap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ itk_wrap_include("itkLevelSetNode.h")
itk_wrap_class("itk::VectorContainer" POINTER)
foreach(d ${ITK_WRAP_IMAGE_DIMS})
foreach(t ${WRAP_ITK_SCALAR})
itk_wrap_template("${ITKM_UI}${ITKM_LSN${t}${d}}" "${ITKT_UI},${ITKT_LSN${t}${d}}")
itk_wrap_template("${ITKM_IT}${ITKM_LSN${t}${d}}" "${ITKT_IT},${ITKT_LSN${t}${d}}")
itk_wrap_template("${ITKM_IT}NPI${d}${ITKM_${t}}" "${ITKT_IT}, itk::NodePair< itk::Index<${d}>, ${ITKT_${t}} >")
endforeach()
endforeach()
Expand Down
2 changes: 1 addition & 1 deletion Modules/Filtering/FastMarching/wrapping/test/FastMarchingImageFilterTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
sigmoid.SetBeta(beta)

NodeType = itk.LevelSetNode[InternalPixelType, Dimension]
NodeContainer = itk.VectorContainer[itk.UI, NodeType]
NodeContainer = itk.VectorContainer[itk.IT, NodeType]
seeds = NodeContainer.New()

seedPosition = [int(argv[3]), int(argv[4])]
Expand Down
2 changes: 1 addition & 1 deletion Modules/Segmentation/LevelSets/include/itkShapePriorMAPCostFunctionBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class ITK_TEMPLATE_EXPORT ShapePriorMAPCostFunctionBase : public SingleValuedCos
using NodeType = LevelSetNode<PixelType, Self::ImageDimension>;

/** Type of container used to store the level set nodes. */
using NodeContainerType = VectorContainer<unsigned int, NodeType>;
using NodeContainerType = VectorContainer<NodeType>;

@N-Dekker N-Dekker Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a potentially breaking change, although in practice, VectorContainer<unsigned int, NodeType> and VectorContainer<NodeType> behave exactly the same.

using NodeContainerPointer = typename NodeContainerType::ConstPointer;

/** Type of the shape signed distance function. */
Expand Down
2 changes: 1 addition & 1 deletion Modules/Segmentation/LevelSets/wrapping/test/GeodesicActiveContourImageFilterTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def main():
node.SetIndex(seedPosition)

seeds = itk.VectorContainer[
itk.UI, itk.LevelSetNode[InternalPixelType, Dimension]
itk.IT, itk.LevelSetNode[InternalPixelType, Dimension]
].New()
seeds.Initialize()
seeds.InsertElement(0, node)
Expand Down
2 changes: 1 addition & 1 deletion Modules/Segmentation/LevelSets/wrapping/test/ShapePriorMAPCostFunctionInitializeTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def check(condition, description):
# fills them in from the fast-marching output and the sigmoid
# edge-potential map.
NodeType = itk.LevelSetNode[InternalPixelType, Dimension]
NodeContainerType = itk.VectorContainer[itk.UI, NodeType]
NodeContainerType = itk.VectorContainer[itk.IT, NodeType]
active_region = NodeContainerType.New()
cost_function.SetActiveRegion(active_region)

Expand Down
2 changes: 1 addition & 1 deletion Modules/Segmentation/LevelSets/wrapping/test/ThresholdSegmentationLevelSetImageFilterTest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
writer.SetInput(thresholder.GetOutput())

NodeType = itk.LevelSetNode[InternalPixelType, Dimension]
NodeContainer = itk.VectorContainer[itk.UI, NodeType]
NodeContainer = itk.VectorContainer[itk.IT, NodeType]
seeds = NodeContainer.New()
seedPosition = [int(argv[3]), int(argv[4])]

Expand Down
Loading