Repository navigation
chore(release): prepare 1.2.0, with WaveFlow's new logo - #19
Merged
Merged
Conversation
WaveFlow replaced its three bars with the W of its name drawn as one and a half periods of a sine (WaveFlow #953). QuickPlay's icons are WaveFlow's: icon-128.png, icon.ico and icon.icns are the new ones from src-tauri/crates/app/icons, and the mark painted in the title bar, the settings and the Continue in WaveFlow button is the kit's small-size symbol, stroked at 46/256 with round ends. The screenshots are retaken.
Version 1.2.0 and its notes in docs/releases/v1.2.0.md: updates on their own, the pin under Wayland, the new logo and the review's fixes.
github-actions
Bot
added
scope: ui
|
Caution Review failedThe pull request is closed. No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Références de version Cargo.toml, README.md, .github/ISSUE_TEMPLATE/bug_report.yml |
La version du paquet, le badge et les exemples du modèle de signalement passent à 1.2.0. Le texte alternatif de la capture dans le README est aussi modifié. |
Note de version docs/releases/v1.2.0.md |
La note décrit les mises à jour, l’épinglage sous Wayland, les corrections annoncées, les instructions d’installation et les limitations connues de la version 1.2.0. |
Rendu du logo src/ui/icons.rs |
Le rendu remplace trois rectangles par une courbe sinusoïdale échantillonnée en 49 points, avec des extrémités arrondies et une épaisseur proportionnelle à la taille de l’icône. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related PRs
- InstaZDLL/waveflow-quickplay#18 — Cette PR ajoute les mises à jour au lancement et leur vérification de signature. La note de version décrit ce comportement.
- InstaZDLL/waveflow-quickplay#15 — Cette PR ajoute l’épinglage Wayland par redémarrage sous XWayland. La note décrit ce comportement.
- InstaZDLL/waveflow-quickplay#14 — Cette PR modifie le packaging Linux et le processus de publication. La note de version décrit les changements associés.
Merge Risk: 
e01d9
-
La mise à jour des références de version, de la note de version et du logo ne présente pas de risque concret identifié avant fusion.
Architecture risk: 
e01d9
-
The change affects 4 systems.
Changed systems:
Cargo.toml,docs,README.md,srcArchitecture concerns
No architecture-level concerns identified.Review details
-
Systems and components
- observed — Cargo.toml (service) was modified; 1 changed file maps to changed impact.
- observed — docs (service) was modified; 1 changed file maps to changed impact.
- observed — README.md (service) was modified; 1 changed file maps to changed impact.
- observed — src (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
- observed — Modified behavior in Cargo.toml: La version déclarée du paquet passe de
1.1.0à1.2.0. - observed — Modified behavior in README.md: Le badge de version passe de 1.1.0 à 1.2.0.
- observed — Modified behavior in README.md: Le texte alternatif de la capture des paramètres indique désormais que la vérification des mises à jour apparaît plus bas dans la page.
- observed — Modified behavior in src/ui/icons.rs: Le commentaire de
Icon::Logodécrit désormais le W ondulé de WaveFlow au lieu de ses trois barres.
-
Pre-merge checks: 
-
Check name Status Explanation Title check Le titre décrit clairement la préparation de la version 1.2.0 et l’ajout du nouveau logo. Il respecte le format Conventional Commits avec le scope release.Description check La description contient le résumé, les tests exécutés, les captures, la checklist, les changements incompatibles et les problèmes liés. Elle signale aussi explicitement que le workflow de publication … Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (4 skipped: 4 … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
La description contient le résumé, les tests exécutés, les captures, la checklist, les changements incompatibles et les problèmes liés. Elle signale aussi explicitement que le workflow de publication n’a pas été testé.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (4 skipped: 4 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.toml,Cargo.lock, README badge, bug form) and its notes indocs/releases/v1.2.0.md: updates on their own (feat(update): check at launch, install the new version on close #18), the pin under Wayland (feat(window): pin under Wayland by restarting under XWayland #15), the review's fixes (fix: the verified findings of the code review #14), GPL-3.0-only (chore(license): GPL-3.0-only, not "or later" #16), LF Windows checksums (fix(release): write the Windows checksums with LF line ends #17).assets/icon-128.png,icon.icoandicon.icnsare WaveFlow's newsrc-tauri/crates/app/iconsfiles. They are the source of the exe, installer, .deb/.rpm/AppImage and macOS app icons.Icon::Logopaints the kit's small-size symbol: one and a half periods of a sine in a 256 box, stroked at 46 with round ends. It shows in the title bar, the settings and the Continue in WaveFlow button.Breaking: none.
How I tested
cargo fmt --check,cargo clippy --locked --all-targets -- -D warningsandcargo test --locked(67 tests) on Windows 11.QUICKPLAY_CAPTURE_DIRand the window driver on Windows, as for 1.1.0.Not covered: the release workflow itself. Its first run will be the
v1.2.0tag, and it carries the changes of #14, #17 and #18 that have never run in CI.Screenshots / clips
docs/screenshots/in this PR.Checklist
type(scope): subject, kebab-case scope)cargo fmt --check,cargo clippy --locked --all-targets -- -D warningsandcargo test --lockedpass locallysrc/i18n/updated, placeholders keptdocs/ARCHITECTURE.mdupdatedLinked issues
None.
Summary by CodeRabbit
.debet.rpmsignalent les mises à jour disponibles sans les installer.