Skip to content

feat(webapp): a card theme picker that can follow the system, with AA contrast across all 14 presets #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
InstaZDLL merged 7 commits into from
Oct 26, 2026
Merged

feat(webapp): a card theme picker that can follow the system, with AA contrast across all 14 presets #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5f302e
fix(webapp): hold wcag aa across the fourteen theme presets
InstaZDLL Oct 26, 2026
2a21604
feat(webapp): a card picker for the themes that can follow the system
InstaZDLL Oct 26, 2026
bc337f3
test(webapp): audit the theme picker and every preset's contrast in t…
InstaZDLL Oct 26, 2026
1c5a13f
Merge branch 'main' of https://github.com/InstaZDLL/waveflow-server i…
InstaZDLL Oct 26, 2026
606728a
feat(webapp): paint each dark preset's own surfaces and weaken the li…
InstaZDLL Oct 26, 2026
2459eef
test(webapp): check the page really paints the dark preset's surfaces
InstaZDLL Oct 26, 2026
20f6307
fix(webapp): follow the system scheme on a MediaQueryList with only a…
InstaZDLL Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions webapp/e2e/studio-nocturne.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,12 +1462,11 @@ test("renders the studio shell and persists appearance preferences", async ({
page.getByRole("heading", { name: "Account", exact: true }),
).toBeVisible();
const preferences = page.locator(".settings-panel").first();
const theme = preferences.getByLabel("Theme");
await theme.selectOption({ index: 1 });
const selectedTheme = await theme.inputValue();
const theme = preferences.getByRole("radiogroup", { name: "Theme" });
await theme.getByRole("radio", { name: "Midnight light" }).check();
await expect
.poll(() => page.evaluate(() => localStorage.getItem("waveflow.theme")))
.toBe(selectedTheme);
.toBe("midnight-light");

const language = preferences.getByLabel("Language");
await language.selectOption("fr");
Expand Down
Loading
Loading