Update empty Python data structure constructors#2289
Open
ndgrigorian wants to merge 1 commit intomasterfrom
Open
Update empty Python data structure constructors#2289ndgrigorian wants to merge 1 commit intomasterfrom
ndgrigorian wants to merge 1 commit intomasterfrom
Conversation
use the simplified constuctors throughtout the project
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2289/index.html |
Collaborator
antonwolfy
reviewed
Apr 24, 2026
| html_context | ||
| except NameError: | ||
| html_context = dict() | ||
| html_context = {} |
Collaborator
There was a problem hiding this comment.
It might be helpful to add any static linter to to check that rule at the pre-commit, but it can be done lately, when introducing the ruff or similar
antonwolfy
approved these changes
Apr 24, 2026
Collaborator
antonwolfy
left a comment
There was a problem hiding this comment.
No more comments from me, LGTM
Thank you @vlad-perevezentsev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates and makes consistent formatting in the project, by opting to replace all calls to the named constructors of empty Python data structures (
list(),dict(), andtuple()) with their simpler constructors ([],{},()).