Skip to content

Fix for dpnp buffer-arg ndarray ignoring offset - #3068

Merged
antonwolfy merged 6 commits into
IntelPython:masterfrom
abagusetty:fix-dpnp-bufferarg-offset
Sep 25, 2026
Merged

Fix for dpnp buffer-arg ndarray ignoring offset#3068
antonwolfy merged 6 commits into
IntelPython:masterfrom
abagusetty:fix-dpnp-bufferarg-offset

Conversation

@abagusetty

@abagusetty abagusetty commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Fixes: #3067

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@intel-python-devops

intel-python-devops commented Sep 10, 2026

Copy link
Copy Markdown

Can one of the admins verify this patch?

@antonwolfy antonwolfy added this to the 0.21.0 release milestone Sep 11, 2026
@coveralls

coveralls commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.479%. remained the same — abagusetty:fix-dpnp-bufferarg-offset into IntelPython:master

antonwolfy
antonwolfy reviewed Sep 11, 2026
View reviewed changes
Comment thread dpnp/dpnp_array.py Outdated
Comment thread dpnp/dpnp_array.py
Comment thread dpnp/dpnp_array.py Outdated
Comment thread dpnp/tests/test_ndarray.py
Comment thread dpnp/tests/test_ndarray.py
@abagusetty
abagusetty force-pushed the fix-dpnp-bufferarg-offset branch from 105d3a7 to 28ed432 Compare September 22, 2026 23:29
vlad-perevezentsev
vlad-perevezentsev approved these changes Sep 24, 2026
View reviewed changes

@vlad-perevezentsev vlad-perevezentsev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @abagusetty

@antonwolfy
antonwolfy merged commit a8f969e into IntelPython:master Sep 25, 2026
125 of 127 checks passed
github-actions Bot added a commit that referenced this pull request Sep 25, 2026
@github-actions
Fix for dpnp buffer-arg ndarray ignoring offset (#3068)
c3f949d 
Fixes: #3067 a8f969e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes
@antonwolfy antonwolfy antonwolfy approved these changes
@ndgrigorian ndgrigorian Awaiting requested review from ndgrigorian ndgrigorian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.21.0 release

Development

Successfully merging this pull request may close these issues.

dpnp.ndarray ctor returns a view at wrong addr with buffer= has non-zero offset

5 participants

@abagusetty @intel-python-devops @coveralls @vlad-perevezentsev @antonwolfy