Repository navigation
task: coverity - #3070
Open
jharlow-intel wants to merge 5 commits into
Open
task: coverity#3070jharlow-intel wants to merge 5 commits into
jharlow-intel wants to merge 5 commits into
Conversation
jharlow-intel
requested review from
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
September 15, 2026 13:23
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3070/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev15=np2py314h8d9cdd5_10 ran successfully. |
Collaborator
ndgrigorian
approved these changes
Sep 24, 2026
antonwolfy
reviewed
Sep 25, 2026
| # Mirrors the build-time requirements in pyproject.toml. dpnp still uses | ||
| # classic scikit-build, so setup.py is the build entry point. | ||
| run: | | ||
| pip install cmake cython ninja numpy scikit-build setuptools wheel \ |
Contributor
There was a problem hiding this comment.
Do we need to pin cython to some version to have a stable report?
Collaborator
Author
There was a problem hiding this comment.
Yes, pinned to cython==3.3.0 in 73c91ca, matching the mkl_fft and mkl-service scans. A Cython upgrade rewrites the generated C and shuffles the CIDs, so an unpinned install would reset the triage whenever PyPI moves. 3.3.0 is also what conda-forge currently resolves for cython>=3.1.0, so the scan builds the same thing as the regular CI until we bump it deliberately.
Unpinned `cython` resolves to whatever PyPI has that Monday, and a Cython upgrade rewrites the generated C, which shuffles Coverity CIDs and loses their triage. Pin 3.3.0, the version conda-forge currently resolves for the regular builds, matching the mkl_fft and mkl-service scans. Also align the upload-artifact pin with master (v7.0.2).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://scan.coverity.com/projects/intelpython-dpnp?tab=overview
Pretty much the same as the others