Repository navigation
Fix test infrastructure issues and remove tests_external #3103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e744fb4
42fbacd
3f08837
85f11aa
b13b761
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -132,11 +132,6 @@ def pytest_collection_modifyitems(config, items): | |
| # global skip file, where gpu device is not supported | ||
| test_exclude_file_gpu = os.path.join(test_path, "skipped_tests_gpu.tbl") | ||
|
|
||
| # global skip file, where gpu device with no fp64 support | ||
| test_exclude_file_gpu_no_fp64 = os.path.join( | ||
| test_path, "skipped_tests_gpu_no_fp64.tbl" | ||
| ) | ||
|
|
||
| # global skip file for cuda backend | ||
| test_exclude_file_cuda = os.path.join(test_path, "skipped_tests_cuda.tbl") | ||
|
|
||
|
|
@@ -161,10 +156,6 @@ def pytest_collection_modifyitems(config, items): | |
| print("") | ||
| if is_gpu or os.getenv("DPNP_QUEUE_GPU") == "1": | ||
| excluded_tests.extend(get_excluded_tests(test_exclude_file_gpu)) | ||
| if not support_fp64: | ||
| excluded_tests.extend( | ||
| get_excluded_tests(test_exclude_file_gpu_no_fp64) | ||
| ) | ||
| if is_cuda: | ||
| excluded_tests.extend(get_excluded_tests(test_exclude_file_cuda)) | ||
| else: | ||
|
|
@@ -178,14 +169,6 @@ def pytest_collection_modifyitems(config, items): | |
| if test_name == item_tbl: | ||
| item.add_marker(skip_mark) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now that -m "slow or not slow" really runs slow tests, two of them fail: |
||
|
|
||
| # Handle the exclusion of tests marked as "slow" | ||
| selected_marker = config.getoption("markexpr") | ||
| if "not slow" in selected_marker: | ||
| skip_slow = pytest.mark.skip(reason="Skipping slow tests") | ||
| for item in items: | ||
| if "slow" in item.keywords: | ||
| item.add_marker(skip_slow) | ||
|
|
||
|
|
||
| def pytest_runtest_teardown(item, nextitem): | ||
| """ | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: _getenv_bool already returns a bool, so the bool(...) wrapper in conftest.py (line 146) can go. DPNP_QUEUE_GPU in conftest.py still uses == "1"; maybe use the same helper there for consistency.