Repository navigation
Move open source SYCL build pins out of the workflow file - #3112
Open
antonwolfy wants to merge 1 commit into
Open
antonwolfy wants to merge 1 commit into
antonwolfy wants to merge 1 commit into
Conversation
The bump-sycl-deps job pushes with GITHUB_TOKEN, which GitHub never allows to update files under .github/workflows/, so its first real bump was rejected. Keep the driver and oneTBB pins in .github/sycl-build-deps.env, load them in os-llvm-sycl-build.yml, and let the bump job rewrite that file.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 17, 2026 11:15
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3112/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev15=np2py314h8d9cdd5_2 ran successfully. |
Collaborator
|
coverage: 82.616% (+0.006%) from 82.61% — fix-bump-sycl-deps-workflow-push into master |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the weekly Bump open source SYCL build deps workflow, which failed on its first real bump in this run:
The job pushes with
GITHUB_TOKEN, and GitHub never allows that token to create or update files under.github/workflows/. There is noworkflowspermission that can be granted to it in thepermissions:block.The pins are moved to a new non-workflow file
.github/sycl-build-deps.env, so the bump job can update them withGITHUB_TOKENand no extra secret is needed:os-llvm-sycl-build.ymlchecks out the repo first and loads the five pins into$GITHUB_ENV. Only the expected keys are exported, and the step fails with a clear error if any of them is missing.bump-sycl-deps.ymlrewrites the values in the new file instead of the workflow.The pin values are unchanged (
2026-WW28). Once merged, a manual run of the bump workflow should open a PR bumping them to2026-WW42.