PersonKeypointReconstruction: adding new method with relaxed limb con… - #143
Closed
divyajoshi11 wants to merge 1 commit into
Closed
divyajoshi11 wants to merge 1 commit into
divyajoshi11 wants to merge 1 commit into
Conversation
divyajoshi11
requested review from
ktshah04 and
peifferjd
and
a lite review from Copilot
August 14, 2026 15:32
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new PersonKeypointReconstructionMethod option that runs implicit trajectory optimization with a lower skeleton (limb-length consistency) weight, enabling a more relaxed limb constraint configuration within the existing DataJoint reconstruction pipeline.
Changes:
- Added a new lookup entry (
reconstruction_method=13) for the relaxed-limb configuration. - Added a corresponding
elifbranch inPersonKeypointReconstruction.make()that callsoptimize_trajectory(..., skeleton_weight=0.05, huber_max=10, robust_camera_weights=False).
Suppressed comments (1)
multi_camera/datajoint/multi_camera_dj.py:291
- This branch relies on exact string matching against reconstruction_method_name. To keep it consistent with the Lookup entry (and with the existing naming style using ", "), update the string here to match the normalized name.
elif reconstruction_method_name == "ImplicitOptKPConf,MaxHuber=10,skel_weight=0.05":
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| {"reconstruction_method": 10, "reconstruction_method_name": r"Implicit Optimization $\\gamma=0.3$"}, | ||
| {"reconstruction_method": 11, "reconstruction_method_name": "Implicit Optimization, MaxHuber=10"}, | ||
| {"reconstruction_method": 12, "reconstruction_method_name": r"Implicit Optimization $\\sigma=50$"}, | ||
| {"reconstruction_method": 13, "reconstruction_method_name": "ImplicitOptKPConf,MaxHuber=10,skel_weight=0.05"}, |
Collaborator
|
Deleting branch since this method is not used anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new PersonKeypointReconstructionMethod with relaxed limb constraint