Updating multi camera schema - #144
Open
divyajoshi11 wants to merge 16 commits into
Open
divyajoshi11 wants to merge 16 commits into
divyajoshi11 wants to merge 16 commits into
Conversation
…ame == Sam3dBody_movi87
…from one camera only
… and detected keypoints
…int names and parent-child pairs
…matic tree joints
divyajoshi11
requested review from
ktshah04 and
peifferjd
and
a lite review from Copilot
August 14, 2026 15:34
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the multi-camera tracking pipeline to support additional pose/body methods and adds new reprojection-quality outputs, including a utility to generate a single-camera reprojection overlay video.
Changes:
- Added skeleton/pair definitions for additional top-down methods (ViTPose-H and SAM3DBody variants) used in reconstruction/visualization.
- Introduced a new DataJoint computed table to store reprojection error per keypoint per camera.
- Added a
make_single_camera_reprojection_videohelper to render detected vs. reprojected keypoints (and optional SAM3D mesh overlay) for one selected camera.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
multi_camera/utils/visualization.py |
Adds single-camera reprojection video generator; modifies existing reprojection video code path. |
multi_camera/datajoint/multi_camera_dj.py |
Adds method-specific skeleton definitions and a new per-keypoint reprojection error computed table. |
Suppressed comments (1)
multi_camera/utils/visualization.py:499
camera_paramsandcamera_namesare used (and asserted) but are no longer fetched/defined in this function, which will raise a NameError and prevent reprojection from working.
if keypoints3d is None:
# get 3D keypoints
keypoints3d = (PersonKeypointReconstruction & key).fetch1("keypoints3d")
assert camera_names == video_camera_name.tolist(), "Videos don't match cameras in calibration"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ktshah04
requested changes
Aug 14, 2026
Added a comment explaining the purpose of the ReprojectionErrorPerKeypoint class and its relation to the ReprojectionError table.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Added a comment to clarify the purpose of the function.
Comment on lines
+338
to
+343
| skeleton = np.array([(joints.index(p[0]), joints.index(p[1])) for p in pairs]) | ||
|
|
||
| # select method for reconstruction | ||
| reconstruction_method_name = (PersonKeypointReconstructionMethodLookup & key).fetch1( | ||
| "reconstruction_method_name" | ||
| ) |
Comment on lines
+885
to
+892
| top_down_method = (TopDownPerson & video_key).fetch1("top_down_method") | ||
| if top_down_method in (34, 35, 37): | ||
| from pose_pipeline.wrappers.sam3d_body import get_sam3d_callback | ||
| sam3d_key = dict(video_key) | ||
| sam3d_key["sam3d_method"] = 3 | ||
| mesh_overlay = get_sam3d_callback(sam3d_key) | ||
| else: | ||
| mesh_overlay = None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for ViTPoseH and SAM3DBody in PersonKeypointReconstruction. Added tables for Reprojection Error per Keypoint. Created function to create overlay of reprojected keypoints on a video from one camera only.