refactor: drop CLUSTER_ERA env var#3452
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the CLUSTER_ERA environment variable from the test/CI plumbing by hardcoding the cluster era to conway, while keeping a CI-only CI_CLUSTER_ERA input to gate setting PROTOCOL_VERSION=11 in the regression runner.
Changes:
- Remove
CLUSTER_ERAconfiguration/validation and references across scripts, docs, and pytest metadata. - Hardcode cluster era to
conwayin runner scripts and defaultTESTNET_VARIANTtoconway_fastwhen not bootstrapping. - Rename CI input usage from
CLUSTER_ERAtoCI_CLUSTER_ERAfor PV11 gating.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/setup_test_env.sh | Stops exporting CLUSTER_ERA in the generated activation script. |
| scripts/check_dev_env.sh | Removes printing of CLUSTER_ERA in dev env checks. |
| runner/regression.sh | Hardcodes cluster era and gates PROTOCOL_VERSION=11 via CI_CLUSTER_ERA. |
| runner/node_upgrade_pytest.sh | Hardcodes cluster era to conway for upgrade pytest runs. |
| runner/env_nightly_pv11 | Drops CLUSTER_ERA from nightly env file. |
| runner/env_nightly_dbsync | Drops CLUSTER_ERA from nightly env file. |
| runner/env_nightly_cli | Drops CLUSTER_ERA from nightly env file. |
| runner/env_nightly | Drops CLUSTER_ERA from nightly env file. |
| README.md | Removes CLUSTER_ERA from documented env vars list. |
| cardano_node_tests/utils/configuration.py | Removes CLUSTER_ERA env handling and hardcodes default TESTNET_VARIANT. |
| cardano_node_tests/tests/conftest.py | Removes CLUSTER_ERA from pytest metadata stash. |
| .github/workflows/regression_reusable.yaml | Writes CI_CLUSTER_ERA instead of CLUSTER_ERA into CI environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CLUSTER_ERA was always "conway"; replace with hardcoded value. CI input renamed to CI_CLUSTER_ERA, used only to gate PROTOCOL_VERSION=11 in runner/regression.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLUSTER_ERA was always "conway"; replace with hardcoded value. CI input renamed to CI_CLUSTER_ERA, used only to gate PROTOCOL_VERSION=11 in runner/regression.sh.