Skip to content

refactor: drop CLUSTER_ERA env var#3452

Merged
mkoura merged 1 commit into
masterfrom
rm_CLUSTER_ERA
May 7, 2026
Merged

refactor: drop CLUSTER_ERA env var#3452
mkoura merged 1 commit into
masterfrom
rm_CLUSTER_ERA

Conversation

@mkoura
Copy link
Copy Markdown
Collaborator

@mkoura mkoura commented May 7, 2026

CLUSTER_ERA was always "conway"; replace with hardcoded value. CI input renamed to CI_CLUSTER_ERA, used only to gate PROTOCOL_VERSION=11 in runner/regression.sh.

@mkoura mkoura requested a review from saratomaz as a code owner May 7, 2026 09:13
@mkoura mkoura requested review from Copilot and removed request for saratomaz May 7, 2026 09:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the CLUSTER_ERA environment variable from the test/CI plumbing by hardcoding the cluster era to conway, while keeping a CI-only CI_CLUSTER_ERA input to gate setting PROTOCOL_VERSION=11 in the regression runner.

Changes:

  • Remove CLUSTER_ERA configuration/validation and references across scripts, docs, and pytest metadata.
  • Hardcode cluster era to conway in runner scripts and default TESTNET_VARIANT to conway_fast when not bootstrapping.
  • Rename CI input usage from CLUSTER_ERA to CI_CLUSTER_ERA for PV11 gating.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
scripts/setup_test_env.sh Stops exporting CLUSTER_ERA in the generated activation script.
scripts/check_dev_env.sh Removes printing of CLUSTER_ERA in dev env checks.
runner/regression.sh Hardcodes cluster era and gates PROTOCOL_VERSION=11 via CI_CLUSTER_ERA.
runner/node_upgrade_pytest.sh Hardcodes cluster era to conway for upgrade pytest runs.
runner/env_nightly_pv11 Drops CLUSTER_ERA from nightly env file.
runner/env_nightly_dbsync Drops CLUSTER_ERA from nightly env file.
runner/env_nightly_cli Drops CLUSTER_ERA from nightly env file.
runner/env_nightly Drops CLUSTER_ERA from nightly env file.
README.md Removes CLUSTER_ERA from documented env vars list.
cardano_node_tests/utils/configuration.py Removes CLUSTER_ERA env handling and hardcodes default TESTNET_VARIANT.
cardano_node_tests/tests/conftest.py Removes CLUSTER_ERA from pytest metadata stash.
.github/workflows/regression_reusable.yaml Writes CI_CLUSTER_ERA instead of CLUSTER_ERA into CI environment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread runner/node_upgrade_pytest.sh
CLUSTER_ERA was always "conway"; replace with hardcoded value.
CI input renamed to CI_CLUSTER_ERA, used only to gate
PROTOCOL_VERSION=11 in runner/regression.sh.
@mkoura mkoura force-pushed the rm_CLUSTER_ERA branch from a35feeb to 6cef2f1 Compare May 7, 2026 09:18
@mkoura mkoura merged commit 0ea5ab6 into master May 7, 2026
3 checks passed
@mkoura mkoura deleted the rm_CLUSTER_ERA branch May 7, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants