Implement Chan, QSem and QSemN#211
Open
bolt12 wants to merge 6 commits into
Open
Conversation
coot
reviewed
May 15, 2025
Comment on lines
+819
to
+822
| getChanContents ch = do | ||
| x <- readChan ch | ||
| xs <- getChanContents ch | ||
| return (x:xs) |
Collaborator
There was a problem hiding this comment.
Does it work without unsafeInterleaveIO? Could you add some tests?
| writeChan = IO.writeChan | ||
| readChan = IO.readChan | ||
| dupChan = IO.dupChan | ||
| getChanContents = IO.getChanContents |
Collaborator
There was a problem hiding this comment.
Suggested change
| getChanContents = IO.getChanContents | |
| getChanContents = IO.getChanContents | |
| writeList2Chan = IO.writeList2Chan |
|
|
||
| ## next version | ||
|
|
||
| - Implements `MonadChan`, `MonadQSem` and `MonadQSemN` instances. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Implements `MonadChan`, `MonadQSem` and `MonadQSemN` instances. | |
| - Added `MonadChan`, `MonadQSem` and `MonadQSemN` type classes and their instances. |
Comment on lines
+872
to
+873
| putMVar m r') | ||
| signalQSem (QSem m) = |
Collaborator
There was a problem hiding this comment.
Let's add some space between definitions
Suggested change
| putMVar m r') | |
| signalQSem (QSem m) = | |
| putMVar m r') | |
| signalQSem (QSem m) = |
Comment on lines
+913
to
+915
| unit <- modifyMVar m $ \(i,a1,a2) -> loop (sz0 + i) a1 a2 | ||
|
|
||
| evaluate unit |
Collaborator
There was a problem hiding this comment.
Suggested change
| unit <- modifyMVar m $ \(i,a1,a2) -> loop (sz0 + i) a1 a2 | |
| evaluate unit | |
| unit <- modifyMVar m $ \(i,a1,a2) -> loop (sz0 + i) a1 a2 | |
| evaluate unit |
|
|
||
| ### Breaking changes | ||
|
|
||
| - Added `MonadChan`, `MonadQSem` and `MonadQSemN` classes. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - Added `MonadChan`, `MonadQSem` and `MonadQSemN` classes. | |
| * Added `MonadChan`, `MonadQSem` and `MonadQSemN` classes. |
😁
Collaborator
|
I am planning to release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128