Repository navigation
Keep resolution unit in Imagick CropModifier - #1551
Merged
olivervogel merged 1 commit intoOct 16, 2026
Merged
olivervogel merged 1 commit into
olivervogel merged 1 commit into
Conversation
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the
crop()one I mentioned under #1548. The canvas it rebuilds on Imagick gets the resolution numbers but not the unit, so anything that's been throughcrop()orresizeCanvas()saves with no DPI.300dpi.pngcomes out with a pHYs of 299 x 299, unit unknown, andtest.jpg(in inches to start with) saves as 72 with no unit either.resolution()still reads 300 afterwards, wich is why the existing test passes.Each frame's resolution and unit now get copied over as they are, so the saved file matches what you'd get without the crop. I didn't force inches the way #1548 does, since a PNG whose pHYs is only an aspect ratio (unit 0) would then come out claiming 1 DPI.