fix(projects): use POST + CSRF for project delete on detail page#1597
Open
polybjorn wants to merge 1 commit into
Open
fix(projects): use POST + CSRF for project delete on detail page#1597polybjorn wants to merge 1 commit into
polybjorn wants to merge 1 commit into
Conversation
The delete button on the project detail page used a GET <a> link, which Base_Controller rejects with show_404() for any non-POST request whose URL contains "delete" (CSRF/prefetch guard). Deleting a project from its detail page therefore 404'd. Convert the link to a POST form with _csrf_field(), matching the pattern already used in the projects list table (partial_projects_table.php). Completes the delete-hardening migration that missed this one link.
Contributor
|
Thanks, man! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delete button on the project detail page (
application/modules/projects/views/view.php) uses a GET<a>link.Base_Controllerrejects any non-POST request whose URL contains "delete" withshow_404()(the CSRF/prefetch guard), so deleting a project from its detail page returns a 404 instead of deleting it.This converts the link to a POST form with
_csrf_field(), matching the delete-hardening already applied elsewhere in the module (partial_projects_table.php, the projects list table). The list-table delete and all other deletes were already POST + CSRF; this detail-page link was the remaining GET link.Test plan
Summary by CodeRabbit