fix: List fromEncodedList reference id arg order#491
Open
cuiweixie wants to merge 1 commit intoIoLanguage:nativefrom
Open
fix: List fromEncodedList reference id arg order#491cuiweixie wants to merge 1 commit intoIoLanguage:nativefrom
cuiweixie wants to merge 1 commit intoIoLanguage:nativefrom
Conversation
Clear the objectForReferenceId message cached argument after IoObject_perform, not before. Previously IONIL immediately after IONUMBER(id) cleared the id before the lookup call. Add ListTest regression (manual REFERENCE encoding, id 42).
Member
|
Retargeting this to the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromEncodedListREFERENCE branch: clear theobjectForReferenceIdcached message argument afterIoObject_perform, not immediately afterIONUMBER(id). The prematureIONILcleared the id before the lookup ran.ListTestregressiontestEncodedListFromEncodedListReferenceIdusing manual bytes matching the encoded format (REFERENCE, id 42) andLobbyhooks.Testing