Skip to content

Harden release follow-up verification - #164

Merged
Ismail-elkorchi merged 1 commit into
mainfrom
fix/release-notes-repository
Jul 21, 2026
Merged

Harden release follow-up verification#164
Ismail-elkorchi merged 1 commit into
mainfrom
fix/release-notes-repository

Conversation

@Ismail-elkorchi

@Ismail-elkorchi Ismail-elkorchi commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • give the artifact-only release-notes publishing job explicit GitHub repository identity
  • model delayed npm attestation availability as a transient registry state
  • replace duplicated fixed-attempt shell loops with bounded exponential backoff that stops immediately on immutable mismatches
  • add regression coverage for no-checkout repository resolution, transient provenance, immutable mismatches, backoff, and workflow wiring

Causes

The release-notes publishing job runs without a checkout, but its gh release edit invocation omitted --repo, so GitHub CLI attempted repository discovery through .git and failed.

npm accepted the exact qualified tarball and produced correct SLSA provenance, but the attestation endpoint returned HTTP 404 for longer than the fixed 55-second post-publish loop. The verifier treated that expected propagation state as an exception and retried all failures indiscriminately.

Validation

  • focused release and registry tooling tests
  • npm run check:fast
  • ESLint
  • actionlint
  • diff whitespace validation
  • live npm metadata and decoded SLSA provenance confirm the published integrity, workflow, release event, tag, GitHub-hosted builder, and exact source commit

@Ismail-elkorchi
Ismail-elkorchi force-pushed the fix/release-notes-repository branch from 97652d5 to 1f170a8 Compare July 21, 2026 18:13
@Ismail-elkorchi
Ismail-elkorchi force-pushed the fix/release-notes-repository branch from 1f170a8 to e707481 Compare July 21, 2026 18:14
@Ismail-elkorchi Ismail-elkorchi changed the title Fix release notes repository resolution Harden release follow-up verification Jul 21, 2026
@Ismail-elkorchi
Ismail-elkorchi merged commit a8a9af5 into main Jul 21, 2026
10 checks passed
@Ismail-elkorchi
Ismail-elkorchi deleted the fix/release-notes-repository branch July 21, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant