refactor: drop orphan Savely/ContentView.swift template stub#27
Merged
Conversation
The file was the original SwiftUI template scaffolding. It's not referenced by Savely.xcodeproj — the canonical ContentView lives at Savely/Views/ContentView.swift and is the one wired into the target. Removing the stale copy to avoid confusion in future searches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Savely/ContentView.swift— the orphan SwiftUI template stub ("Hello, world!") created on 16/10/24.Why
Two
ContentView.swiftfiles existed on disk but only one was wired into the Xcode target.Savely.xcodeproj/project.pbxprojline 505 references the file inside theViewsgroup, which resolves toSavely/Views/ContentView.swift— that's the canonical one with the realAppViewModelrouting (loading / loggedOut / onboarding / main). The root-level copy was the original SwiftUI template that the project moved past months ago; it was never compiled (Xcode doesn't even know it exists), so deleting it is a pure cleanup with zero blast radius.This is Task 1 of
docs/plans/maintenance-cleanup.md.Test plan
xcodebuild build -scheme Savely -destination 'platform=iOS Simulator,name=iPhone 17 Pro'— passesxcodebuild test -scheme Savely -destination 'platform=iOS Simulator,name=iPhone 17 Pro' -skip-testing:SavelyUITests— passesswiftlint lint— no new warnings introduced (the 10 preexistingforce_unwrappingwarnings are Task 3 of the plan)project.pbxprojedit needed — the orphan was never referencedSavely/Views/ContentView.swiftandSplashScreenView.swift:25(only consumer) untouchedRisks
None material. The deleted file:
project.pbxproj(verified by grep; only oneContentView.swiftPBXFileReference exists, and it's inside theViewsgroup)ContentViewsymbol identical in name to the canonical one — Swift was not compiling it, so no symbol collision existed at build timeNotes for reviewer
Local builds were validated on
iPhone 17 Prorather thaniPhone 16 Pro(per CLAUDE.md /ci.yml) because Xcode 26 no longer ships the 16 Pro simulator locally. CI'smacos-15runner still has it, so CI runs unchanged. Updating the documented destination is a separate small chore — flagged for follow-up.🤖 Generated with Claude Code