Repository navigation
Fix dated CDE ticker NRE and futures market-order postOnly - #35
Merged
JKorf merged 2 commits intoAug 13, 2026
Merged
Conversation
Dated CDE contracts (e.g. XPP-20DEC30-CDE) have no PerpetualDetails, so the null-forgiving access in GetFuturesTicker(s)Async threw NRE. Use null-conditional and leave FundingRate/NextFundingTime unset. Futures PlaceOrderAsync sent postOnly=false for non-LimitMaker orders. Coinbase rejects that on market_market_ioc with proto unknown field "post_only". Match the spot path: true for LimitMaker, null otherwise. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetFuturesTickerAsync/GetFuturesTickersAsyncused null-forgiving access onFutureProductDetails/PerpetualDetails. Dated CDE contracts (e.g.XPP-20DEC30-CDE) legitimately have no perpetual funding details, which caused aNullReferenceException. Use null-conditional and leaveFundingRate/NextFundingTimeunset.PlaceFuturesOrderAsyncpassedpostOnly: falsefor non-LimitMakerorders. Coinbase rejects that onmarket_market_iocwithproto: unknown field "post_only". Match the spot path:trueforLimitMaker,nullotherwise.Test plan
GetFuturesTicker(s)Asyncfor a dated CDE symbol — no NRE; funding fields nullGetFuturesTicker(s)Asyncfor a perpetual — funding fields still populated when presentpost_onlyproto error)postOnly: true