Skip to content

fix(ci): validate-tests-merge exits 1 on zero merged test files too#8174

Merged
JSONbored merged 1 commit into
mainfrom
fix/ci-merge-reports-zero-test-files
Jul 23, 2026
Merged

fix(ci): validate-tests-merge exits 1 on zero merged test files too#8174
JSONbored merged 1 commit into
mainfrom
fix/ci-merge-reports-zero-test-files

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Test plan

#8167 fixed the per-shard --changed case (exits 0 with "No test files
found"), but --mergeReports exits 1 for the same condition -- a different
code path, not covered by that fix. Confirmed live: PR #8168 (the same
docs-only PR #8167 was meant to unblock) passed all 3 validate-tests shards
but still failed validate-tests-merge with "No test files found, exiting
with code 1", even with COVERAGE_NO_THRESHOLDS already disabling the
threshold check.

Only treats that exact case as success, and only when COVERAGE_NO_THRESHOLDS
is set (i.e. this run is the scoped case to begin with) -- in the unscoped
full-suite case, "no test files found" while merging is still a real
failure worth surfacing loudly.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jul 23, 2026
@JSONbored
JSONbored merged commit 0c2a275 into main Jul 23, 2026
9 of 10 checks passed
@JSONbored
JSONbored deleted the fix/ci-merge-reports-zero-test-files branch July 23, 2026 08:23
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
20673 1 20672 17
View the top 1 failed test(s) by shortest run time
test/unit/codecov-policy.test.ts > Codecov policy > fails closed when the backend coverage report is missing or cannot upload
Stack Traces | 0.129s run time
AssertionError: expected '${{ success() && steps.coverage.outpu…' to be '${{ success() }}' // Object.is equality

Expected: "${{ success() }}"
Received: "${{ success() && steps.coverage.outputs.no_tests_matched != 'true' }}"

 ❯ test/unit/codecov-policy.test.ts:62:35

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant