fix(ci): validate-tests-merge exits 1 on zero merged test files too#8174
Merged
Conversation
#8167 fixed the per-shard --changed case (exits 0 with "No test files found"), but --mergeReports exits 1 for the same condition -- a different code path, not covered by that fix. Confirmed live: PR #8168 (the same docs-only PR #8167 was meant to unblock) passed all 3 validate-tests shards but still failed validate-tests-merge with "No test files found, exiting with code 1", even with COVERAGE_NO_THRESHOLDS already disabling the threshold check. Only treats that exact case as success, and only when COVERAGE_NO_THRESHOLDS is set (i.e. this run is the scoped case to begin with) -- in the unscoped full-suite case, "no test files found" while merging is still a real failure worth surfacing loudly.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--changedcase (exits 0 with "No test files found"), but--mergeReportsexits 1 for the same condition -- a different code path, not covered by that fix.validate-testsshards but still failedvalidate-tests-mergewith "No test files found, exiting with code 1", even withCOVERAGE_NO_THRESHOLDSalready disabling the threshold check.COVERAGE_NO_THRESHOLDSis set (i.e. this run is the scoped case to begin with) -- in the unscoped full-suite case, "no test files found" while merging is still a real failure worth surfacing loudly.Test plan
.github/workflows/ci.yml; nosrc/**changes, so no Codecov impact.actionlint .github/workflows/ci.ymlpasses.validate-tests-mergeonce this merges and it's re-triggered is the real verification.