Skip to content

chore(ci): rename self-host-nightly.yml to self-host-maintenance.yml#8483

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
RealDiligent:fix/critical-issue-rename-selfhost-workflow-8397
Jul 24, 2026
Merged

chore(ci): rename self-host-nightly.yml to self-host-maintenance.yml#8483
JSONbored merged 1 commit into
JSONbored:mainfrom
RealDiligent:fix/critical-issue-rename-selfhost-workflow-8397

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

.github/workflows/self-host-nightly.yml has no schedule: triggerworkflow_dispatch: {} is its only one, and the file's own header states that is deliberate ("deliberately not scheduled while the review stack is running without colocated GitHub Actions runners"). Its name: field already reads self-host maintenance; only the filename still implied an unattended nightly job — a holdover from before #4899 generalized the workflow and dropped its schedule.

That is misleading to anyone surveying .github/workflows/ by filename, which is the usual way to scan a repo's automation. Renamed to self-host-maintenance.yml, matching its own name: field and this repo's convention of filename mirroring name: (e.g. stuck-check-watchdog.ymlStuck required-check watchdog, cache-cleanup.ymlClean up closed-PR caches).

Pure renamegit diff --stat reports 1 file changed, 0 insertions(+), 0 deletions(-) and git records it as a rename (R), so history is preserved. No name:, trigger, job, or any other content change.

I independently re-verified the issue's claim that nothing else references the old filename before renaming:

$ grep -rln "self-host-nightly" . --include="*.md" --include="*.yml" --include="*.yaml" --include="*.ts" --include="*.json"
./.github/workflows/self-host-nightly.yml      # the file itself, nothing else

Closes #8397

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • This PR renames one workflow file and changes zero lines of content, so there is no TypeScript, UI, MCP, worker, or dependency surface to exercise: typecheck, test:coverage, test:workers, build:mcp/test:mcp-pack, ui:*, and npm audit are all unaffected. npm run actionlint (the check that does cover .github/workflows/**) passes, and git diff --check is clean.
  • No new test, deliberately: there is no behavior to test — a filename carries no runtime semantics for a workflow_dispatch-only workflow, and the workflow body is byte-identical. The meaningful verification is the grep above proving no reference breaks, plus actionlint still accepting the file at its new path.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — a workflow-file rename; no visible UI, frontend, docs, or extension change.

Notes

  • Renaming a workflow file resets that workflow's run history in the Actions UI (GitHub keys history by path). For a workflow_dispatch-only operator hook with no schedule this is a cosmetic, one-time effect; flagging it explicitly since it is the only externally visible consequence of the rename.

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 24, 2026 15:03
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

The workflow has no schedule: trigger -- workflow_dispatch is its only one, and
its own header says that is deliberate while the review stack runs without
colocated runners. Its name: field already reads "self-host maintenance"; only
the filename still implied an unattended nightly job, which is misleading when
surveying .github/workflows/ by filename.

Pure git rename: no content, trigger, or job changes. Nothing else in the repo
referenced the old filename.

Closes JSONbored#8397
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.51%. Comparing base (32f37d5) to head (d3ab839).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8483       +/-   ##
===========================================
+ Coverage   66.08%   92.51%   +26.42%     
===========================================
  Files         791      791               
  Lines       79333    79343       +10     
  Branches    23961    23967        +6     
===========================================
+ Hits        52430    73403    +20973     
+ Misses      22909     4807    -18102     
+ Partials     3994     1133     -2861     
Flag Coverage Δ
shard-1 59.31% <ø> (?)
shard-2 45.64% <ø> (?)
shard-3 56.14% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 466 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 24, 2026
@loopover-orb

loopover-orb Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-24 15:48:43 UTC

1 file · 1 AI reviewer · no blockers · CI green · clean

⏸️ Suggested Action - Manual Review

  • Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): .github/workflows/self-host-maintenance.yml (matched .github/workflows/**), .github/workflows/self-host-nightly.yml (matched .github/workflows/**).

Review summary
Pure rename of `.github/workflows/self-host-nightly.yml` to `self-host-maintenance.yml` with no content changes, matching the file's existing `name:` field which already reads 'self-host maintenance' and correcting a stale filename left over from #4899's removal of the schedule trigger. Git records this as a rename so history is preserved, and the PR author verified no other files reference the old filename. The one leftover artifact is the `concurrency.group: self-host-nightly` value, which still uses the old name but is functionally harmless since it's just a string key.

Nits — 3 non-blocking
  • The `concurrency: group: self-host-nightly` field on the renamed file still references the old name; consider renaming it to `self-host-maintenance` for consistency, though this has no functional impact since it's just a concurrency-group key.
  • Rename the `concurrency.group` value to `self-host-maintenance` in a follow-up for full naming consistency, since it's currently the only remaining trace of the old filename.
  • Touches a guarded path — held for manual review — A maintainer must review and merge this change.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ⚠️ Gate result — Not blocking (Advisory; not blocking this PR.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8397
Related work ⚠️ 1 scoped overlap Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 361 registered-repo PR(s), 142 merged, 36 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 361 PR(s), 36 issue(s).
Improvement ℹ️ Insufficient signal risk: clean · value: insufficient-signal
Linked issue satisfaction

Addressed
The PR performs exactly the requested filename-only rename from self-host-nightly.yml to self-host-maintenance.yml, matching the workflow's own name: field, with no other content changes, and includes verification that no other files reference the old filename.

Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 361 PR(s), 36 issue(s).
  • Related work: Titles/paths share 8 meaningful terms. (PR #8342, PR #8273)
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 3 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 24, 2026
@JSONbored
JSONbored merged commit 7133840 into JSONbored:main Jul 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

self-host-nightly.yml's filename no longer matches its manual-only, unscheduled nature

2 participants