Skip to content

test(signals): cover decidePublicSurface's oss_maintainer + not_checked label fallback #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeffrey701 wants to merge 1 commit into from
Closed

test(signals): cover decidePublicSurface's oss_maintainer + not_checked label fallback #8495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions test/unit/settings-preview.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,28 @@ describe("decidePublicSurface", () => {
expect(decision).toMatchObject({ skipped: false, willComment: false, willLabel: false, willCheckRun: false, actions: ["none"] });
expect(decision.summary).toMatch(/no surface action is enabled/);
});

// #8324: the oss_maintainer + not_checked fallback in willLabel (settings-preview.ts:149). For this combo
// shouldApplyPrLabel always returns false (line 39), so the inline second disjunct alone decides willLabel —
// exercise every operand of its && chain. (The false sides of the audienceMode/minerStatus operands are already
// covered by the confirmed / gittensor_only cases above.)
it("applies the oss_maintainer + not_checked label fallback per autoLabelEnabled and publicSurface", () => {
const decide = (over: Partial<RepositorySettings>) =>
decidePublicSurface({
settings: settings({ publicAudienceMode: "oss_maintainer", commentMode: "off", checkRunMode: "off", ...over }),
authorLogin: "drive-by",
authorType: "User",
authorAssociation: "NONE",
minerStatus: "not_checked",
});
// autoLabelEnabled + a label-bearing surface → the fallback applies the label.
expect(decide({ autoLabelEnabled: true, publicSurface: "comment_and_label" })).toMatchObject({ willLabel: true, actions: ["label"] });
expect(decide({ autoLabelEnabled: true, publicSurface: "label_only" })).toMatchObject({ willLabel: true, actions: ["label"] });
// comment-only surface → no label even with autoLabel on (the disjunct's own publicSurface check excludes it).
expect(decide({ autoLabelEnabled: true, publicSurface: "comment_only" }).willLabel).toBe(false);
// autoLabel off → the fallback can't apply the label; falls back to shouldApplyPrLabel's (also false) result.
expect(decide({ autoLabelEnabled: false, publicSurface: "comment_and_label" }).willLabel).toBe(false);
});
});

describe("buildRepoSettingsPreview", () => {
Expand Down
Loading