feat: support MERGE ... WHEN NOT MATCHED BY TARGET / BY SOURCE (#2421) - #2453
Open
fudianchn wants to merge 1 commit into
Open
feat: support MERGE ... WHEN NOT MATCHED BY TARGET / BY SOURCE (#2421)#2453fudianchn wants to merge 1 commit into
fudianchn wants to merge 1 commit into
Conversation
BigQuery and SQL Server allow the MERGE NOT MATCHED clause to be
qualified with BY TARGET (allows INSERT) or BY SOURCE (allows
UPDATE/DELETE), e.g.:
MERGE INTO t USING s ON ...
WHEN NOT MATCHED BY TARGET THEN INSERT (...)
WHEN NOT MATCHED BY SOURCE THEN DELETE
Previously JSQLParser rejected the BY TARGET/BY SOURCE qualifier as an
UnsupportedStatement (JSQLParser#2421).
Add an optional [BY TARGET|SOURCE] to the WHEN NOT MATCHED production,
allow INSERT/update/delete on that branch, and store the side on the
MergeInsert/MergeUpdate/MergeDelete operations via a new MergeSide enum.
Standard WHEN [NOT] MATCHED (no BY) keeps working unchanged.
TARGET/SOURCE are matched as identifiers (not reserved keywords), so
existing SQL using them as column/table names is unaffected.
Fixes JSQLParser#2421
Signed-off-by: 付典 <fudianchn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BigQuery and SQL Server allow the
MERGE ... WHEN NOT MATCHEDclause to be qualified withBY TARGET(default, allowsINSERT) orBY SOURCE(allowsUPDATE/DELETE). JSQLParser currently rejects it as anUnsupportedStatement(#2421):The grammar's
MergeWhenNotMatchedhad noBYbranch and was hard-wired toINSERT.Change
JSqlParserCC.jjt): add an optional[BY TARGET|SOURCE]toWHEN NOT MATCHED, and let that branch produceINSERT,UPDATE, orDELETE(extractedMergeInsertClausehelper so all three branches stay simple, mirroringMergeWhenMatched). Standard SQLWHEN [NOT] MATCHED(noBY) is unchanged.MergeSide { TARGET, SOURCE }enum + asidefield onMergeInsert/MergeUpdate/MergeDelete, rendered by bothtoString()and theMergeDeParservisitor.TARGET/SOURCEare matched as identifiers (S_IDENTIFIER) rather than reserved keywords, so existing SQL that uses them as column/table names is unaffected.Verification
MergeTestcoverBY TARGET(INSERT) +BY SOURCE(DELETE), andBY SOURCE ... THEN UPDATEwith anANDpredicate — each with a round-tripassertSqlCanBeParsedAndDeparsedplus AST assertions on thesidefield.checkstyle/pmd/license:check-file-headerclean.WHEN MATCHED ... UPDATE/DELETEandWHEN NOT MATCHED ... INSERTtests keep passing (23 pre-existing Merge tests unaffected).Fixes #2421.