Repository navigation
Accept Snowflake COPY GRANTS in CREATE TABLE - #2805
Merged
manticore-projects merged 1 commit intoOct 13, 2026
Merged
manticore-projects merged 1 commit into
manticore-projects merged 1 commit into
Conversation
COPY became a reserved keyword with the COPY statement support in JSQLParser#2643, so the generic CREATE TABLE option rule no longer accepts it and CREATE TABLE ... COPY GRANTS fails to parse. Add COPY GRANTS as an explicit table option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
edeadington
marked this pull request as ready for review
October 13, 2026 11:12
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake's
COPY GRANTSclause onCREATE TABLEno longer parses:This used to work: there was never a dedicated rule for it, but
COPYandGRANTSwere plain identifiers, so the generic table option rule (CreateParameter()) accepted them. #2643 madeCOPYa reserved keyword for the newCOPYstatement, and the generic rule only accepts identifiers plus a fixed list of keywords, soCOPY GRANTSstopped parsing as a side effect.This PR adds
COPY GRANTSas an explicit option inCreateTableOption(). It's only taken whenCOPYis directly followed byGRANTS, soCOPYanywhere else, including aCOPYstatement, is parsed as before. The option is kept as a raw table option, so it prints back asCOPY GRANTS.The new test covers both Snowflake forms: after the table name in a
CREATE TABLE ... ASquery, and after a column list.