Repository navigation
Drop native macOS release and CI jobs - #1670
Merged
Merged
Conversation
This was referenced Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves Linux job definitions, ARM opt-in policy, concurrency and release smoke checks. Updates active CI/testing documentation; historical research stays untouched. Broader platform documentation and ADR 0003 are assigned to #1668.
Closes #1666
Evidence
After:
dist plan --output-format=jsonemits exactly the two static Linux build targets on their Ubuntu runners; installer target triples are Linux-only. A structural comparison confirms existing Linux jobs and concurrency are unchanged.python3 scripts/generate-release.pyandpython3 scripts/generate-release.py --checkpassed. Generatedrelease.ymlis byte-identical: its matrix comes from the runtime release plan.python3 -m unittest discover -s scripts -p test_generate_release.py: 3 tests passed.scripts/affected-tests main: passed, including site, Console and the full Rust suite. Localcargo testtook 4,378.39 seconds, including 3m 27s compilation, withRUST_TEST_THREADS=3. Local setup uses Python 3.11 and the installed Playwright browser cache.828cdfa7, including both Linux release builds and ARM, Rocky and WSL smoke checks. ARM CI remains intentionally skipped for this PR into a Spec branch.Existing validation seams: release generator CLI and cargo-dist release plan; CI job/concurrency definitions; repository affected-test selector. No new tests were needed for these configuration removals.
Review coverage
Independent
thirdshift-code-reviewreviews usedissue-1665as the fixed point. Standards: 0 findings. Spec: 0 findings. Both reviewers read all five changed files:.config/nextest.toml,.github/workflows/ci.yml,dist-workspace.toml,docs/ci-performance.md, anddocs/testing.md.Unread changed files: none on either axis. Generated-output exclusions: none.
Reports and each axis's full files-read list are retained in
.thirdshift-review-AHJC1Q/standards.mdand.thirdshift-review-AHJC1Q/spec.md, with counts insummary.json.Unaddressed findings
Standards
None.
Spec
None.
Security
None. Guidance-mode security review against pinned merge base
86c8887f557b225573a32552bb3fb0927bc04edfcovered all five changed files and supporting CI, release generation, artifact handoffs, publication hooks and update code. No introduced security findings were identified.Source comparison confirmed retained Linux CI job content and concurrency are unchanged; release permissions, smoke checks and publication gates are unchanged. Reused passing CI and Release checks on unchanged head
828cdfa7, asdocs/testing.mdpermits. No source changes were required.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Configuration can be reverted. Future releases stop publishing native macOS binaries; existing release artifacts are unaffected.
Blast Radius: CI
Removes native macOS validation and release builds. Linux build/test policies and publication hooks remain in place.
Built with codex codex-cli 0.166.0 · gpt-6.1-sol · xhigh