Implemented generic multimodal chat handler.#125
Open
alcoftTAO wants to merge 2 commits intoJamePeng:mainfrom
Open
Implemented generic multimodal chat handler.#125alcoftTAO wants to merge 2 commits intoJamePeng:mainfrom
alcoftTAO wants to merge 2 commits intoJamePeng:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
It automatically uses the model's chat template and replaces all of the model's multimodal tags with the
media_markertag.This allows a much easier implementation for multimodal models, since the chat template doesn't need to be hard-coded for each model.
How to use it?
It is as simple as passing the
clip_model_pathparameter to theLlamaclass when created.Note
Using the previous implementation (e.g.
Qwen35ChatHandler) still works.I'm also looking forward to implement more model architectures. Please, reply if you want me to implement any.