Repository navigation
Load any Pyodide package on first import - #50
Merged
Merged
Conversation
…n imports it, found by its module in Pyodide's lockfile (py.lockfile), instead of the two in LAZY (scipy, scikit-image): a page's own modules import Pillow (or anything else of Pyodide's) inside their functions and list nothing, as cellmap-flow asked; design.md and the CHANGELOG say so, under a new Unreleased heading, which test_docs' version check now skips and contributing.md's release steps name
…yodide ships but not listed loads when first imported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser engine's Pyodide workers now load any package Pyodide ships the first time their Python imports it. Before, only scipy and scikit-image loaded this way.
web/src/pyworker.ts. On a failed import, the worker looks the module up in Pyodide's lockfile (py.lockfile, which lists the modules each package provides) and loads that package. This replaces theLAZYtable. There is no new option, so a page imports inside its function and lists nothing.PILmaps to Pillow,scipyto scipy andskimageto scikit-image.Unreleasedheading.tests/test_docs.py's version check now skips that heading, and contributing.md's release steps name it.