Repository navigation
Fix the registration demos after #51: axis types and arrays without attributes - #52
Merged
Merged
Conversation
…no attributes of their own, both broken in #51: openImage built axes from name and unit alone, so the register page's before and after views served t and c untyped and Neuroglancer read them as space (the EASI-FISH demo's moving round out of place), and an array zarrita gives no attrs (the fly brain demo's) failed on _ARRAY_DIMENSIONS; the axis typing worldarray uses (axisTypes) and TO_SECONDS move to placement.ts, shared by layout.ts and openImage, and placeZarr, openImage and a zarr array's source take missing attributes as none; a test of both
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two regressions that #51 introduced in the browser engine's registration demos.
Fly brain demo: "Cannot read properties of undefined (reading '_ARRAY_DIMENSIONS')". The example's arrays have no attributes of their own, and zarrita gives
attrsas undefined for them.placeZarrreadattrs._ARRAY_DIMENSIONSwithout allowing for that.placeZarr,openImageand the zarr array source now treat missing attributes as none.EASI-FISH demo: the moving round appeared out of place.
openImageused to keep each OME axis'stype; worldarray 0.3: served metadata, chunk keys and the browser reader #51 built the axes from name and unit only. The register page writesmoving.axesinto the OME metadata of its before/after views, sotandcwere served untyped, and Neuroglancer stopped treating them as time and channel. The placement itself was unchanged.The typing rule worldarray uses (
axisTypes, withTO_SECONDS) moves toplacement.ts, and bothlayout.tsandopenImagenow use it, so images carrytime,channelandspaceagain.Checked under Node on the demos' real metadata (the brain example's local copy, and the two EASI-FISH rounds' documents from S3):
openImagenow returns the same axes, types, scales and shifts as before #51, while main as merged reproduces both symptoms. A test inweb/test/metadata.test.tscovers an array with no attributes and the axis types.