fix: nix packaging#147
Open
es-sai-fi wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThis PR fixes the Nix packaging for
|
| Filename | Overview |
|---|---|
| .gitignore | Adds /result to prevent the Nix build artifact symlink from being committed; /result-* for multi-output builds is not covered. |
| package.nix | Fixes Nix derivation by splitting name into pname+version, and stubs out vergen env vars so the build succeeds without git access. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["nix build"] --> B["rustPlatform.buildRustPackage"]
B --> C["Set env vars\nVERGEN_GIT_DESCRIBE=dev\nVERGEN_BUILD_DATE=unknown"]
C --> D["cargo build\n(no git access)"]
D --> E["result symlink\n→ /nix/store/…-gitv-0.4.3"]
E --> F{".gitignore\n/result\n/result-*?"}
F -->|"/result matched"| G["result NOT committed ✓"]
F -->|"result-bin / result-dev\nnot matched"| H["result-* may be committed ⚠"]
Reviews (4): Last reviewed commit: "fix: nix packaging" | Re-trigger Greptile
4bc8eb2 to
1db2141
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #146.