Skip to content

fix: nix packaging#147

Open
es-sai-fi wants to merge 1 commit into
JayanAXHF:mainfrom
es-sai-fi:nix-fix
Open

fix: nix packaging#147
es-sai-fi wants to merge 1 commit into
JayanAXHF:mainfrom
es-sai-fi:nix-fix

Conversation

@es-sai-fi
Copy link
Copy Markdown
Contributor

Solves #146.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 12, 2026

Greptile Summary

This PR fixes the Nix packaging for gitv by correcting the derivation structure and preventing build artifacts from polluting the repository. Splits name = "gitv" into pname = "gitv" + version = "dev" to conform with Nixpkgs conventions, and stubs VERGEN_GIT_DESCRIBE/VERGEN_BUILD_DATE so vergen doesn't attempt git access during the sandboxed Nix build. Adds /result to .gitignore to prevent the nix build output symlink from being committed; /result-* for multi-output builds is not yet covered.

Important Files Changed

Filename Overview
.gitignore Adds /result to prevent the Nix build artifact symlink from being committed; /result-* for multi-output builds is not covered.
package.nix Fixes Nix derivation by splitting name into pname+version, and stubs out vergen env vars so the build succeeds without git access.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["nix build"] --> B["rustPlatform.buildRustPackage"]
    B --> C["Set env vars\nVERGEN_GIT_DESCRIBE=dev\nVERGEN_BUILD_DATE=unknown"]
    C --> D["cargo build\n(no git access)"]
    D --> E["result symlink\n→ /nix/store/…-gitv-0.4.3"]
    E --> F{".gitignore\n/result\n/result-*?"}
    F -->|"/result matched"| G["result NOT committed ✓"]
    F -->|"result-bin / result-dev\nnot matched"| H["result-* may be committed ⚠"]
Loading

Reviews (4): Last reviewed commit: "fix: nix packaging" | Re-trigger Greptile

Comment thread package.nix
Comment thread package.nix
@es-sai-fi es-sai-fi force-pushed the nix-fix branch 2 times, most recently from 4bc8eb2 to 1db2141 Compare May 12, 2026 21:50
Comment thread result Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant