Skip to content

refactor: reuse MCP discovery chain #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JerrettDavis merged 1 commit into from
Jun 2, 2026
Merged

refactor: reuse MCP discovery chain #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions src/JD.SemanticKernel.Extensions.Mcp/Registry/McpRegistry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ namespace JD.SemanticKernel.Extensions.Mcp.Registry;
public sealed class McpRegistry : IMcpRegistry
{
private readonly IReadOnlyList<IMcpDiscoveryProvider> _providers;
private readonly AsyncActionChain<McpDiscoveryState> _discoveryChain;

/// <summary>
/// Initializes a new instance of <see cref="McpRegistry"/>.
Expand All @@ -31,6 +32,7 @@ public McpRegistry(IReadOnlyList<IMcpDiscoveryProvider> providers)
if (providers is null) throw new ArgumentNullException(nameof(providers));
#endif
_providers = providers;
_discoveryChain = BuildDiscoveryChain(_providers);
}

/// <inheritdoc/>
Expand All @@ -39,11 +41,20 @@ public async Task<IReadOnlyList<McpServerDefinition>> GetAllAsync(
{
var merged = new Dictionary<string, McpServerDefinition>(StringComparer.OrdinalIgnoreCase);
var state = new McpDiscoveryState(merged);
var chainBuilder = AsyncActionChain<McpDiscoveryState>.Create();

foreach (var provider in _providers)
await _discoveryChain.ExecuteAsync(state, cancellationToken).ConfigureAwait(false);

return new List<McpServerDefinition>(merged.Values).AsReadOnly();
}

private static AsyncActionChain<McpDiscoveryState> BuildDiscoveryChain(
IReadOnlyList<IMcpDiscoveryProvider> providers)
{
var builder = AsyncActionChain<McpDiscoveryState>.Create();

foreach (var provider in providers)
{
chainBuilder.Use(async (current, token, next) =>
builder.Use(async (current, token, next) =>
{
token.ThrowIfCancellationRequested();
var servers = await provider.DiscoverAsync(token).ConfigureAwait(false);
Expand All @@ -52,10 +63,7 @@ public async Task<IReadOnlyList<McpServerDefinition>> GetAllAsync(
});
}

var chain = chainBuilder.Build();
await chain.ExecuteAsync(state, cancellationToken).ConfigureAwait(false);

return new List<McpServerDefinition>(merged.Values).AsReadOnly();
return builder.Build();
}

/// <inheritdoc/>
Expand Down
Loading