Skip to content

feat: add year filter to customization studio#191

Merged
JhaSourav07 merged 5 commits into
JhaSourav07:mainfrom
Charan-Mugada:feature/year-filter-customization
May 20, 2026
Merged

feat: add year filter to customization studio#191
JhaSourav07 merged 5 commits into
JhaSourav07:mainfrom
Charan-Mugada:feature/year-filter-customization

Conversation

@Charan-Mugada
Copy link
Copy Markdown
Contributor

@Charan-Mugada Charan-Mugada commented May 18, 2026

Description

Added a dynamic Year filter to the Customization Studio.

Fixes #142

Changes Made

  • Added a Year dropdown for selecting contribution years
  • Implemented dynamic year generation based on the current year
  • Added year state handling in page.tsx
  • Updated query parameter generation to append &year= only when a specific year is selected
  • Ensured selecting Current Year removes the year query parameter
  • Updated live preview and export snippet generation accordingly
  • Optimized current year calculation by moving it outside the loop
  • Added (current) label for better UX consistency
  • Repositioned the Year selector below Theme Presets

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Before

Old Year Dropdown

img1

Old Placement

img2

After

Improved Year Selector UI

img3

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/customize).
  • I have run npm run format locally and resolved all errors.
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have starred the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (not applicable for this UI-only change).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 18, 2026

@Charan-Mugada is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the needs-details This PR is missing required description details. label May 18, 2026
@github-actions
Copy link
Copy Markdown

👋 Hey @Charan-Mugada, it looks like you didn't use our PR template!

The section ## Pillar is missing from your PR description.

Please update your PR description to include all required sections so we can review this properly:

  • ## Description — What does this PR do? Which issue does it fix?
  • ## Pillar — Which contribution pillar does this fall under?
  • ## Checklist — Have you ticked off the quality checklist?

You can find the full template in CONTRIBUTING.md. Just edit your PR description and the needs-details label will be removed automatically. 🙌

@github-actions
Copy link
Copy Markdown

👋 Hey @Charan-Mugada, welcome to CommitPulse! 🎉

Thanks for opening your first pull request — this is a big deal and we appreciate the effort!

While you wait for a review, please double-check:

  • ✅ You've read the CONTRIBUTING.md checklist
  • npm run lint, npm run format, and npm run test all pass locally
  • ✅ Your PR has a visual preview if it touches any SVG output
  • 💬 You've joined our Discord for faster PR feedback

A maintainer will review your PR shortly. Hang tight! 🚀

@github-actions github-actions Bot removed the needs-details This PR is missing required description details. label May 18, 2026
@Charan-Mugada
Copy link
Copy Markdown
Contributor Author

@JhaSourav07 All CI checks are passing now
Implemented the dynamic year filter and fixed the formatting issues. Please review once when free.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
commitpulse Ready Ready Preview, Comment May 19, 2026 9:39am

@JhaSourav07
Copy link
Copy Markdown
Owner

@Aamod007

Can you review this?

@JhaSourav07
Copy link
Copy Markdown
Owner

@Charan-Mugada

PR description should be as PR template and you should be following every point mentioned in the checklist in order to merge this PR.
I hope you understand and you will do it.

@Aamod007
Copy link
Copy Markdown

@Charan-Mugada One quick fix before we merge:

  • You're calculating the current year inside the loop that generates the dropdown options. It's a tiny optimization, but it would be better to move that calculation outside the loop so it only runs once instead of on every iteration.
  • And fix the PR description format

Optional polish ideas if you have time:

  • Adding a small (current) tag next to this year's option could make the selector feel more consistent with how the speed dropdown labels its choices.

  • You may also want to move the year selector below the theme presets section. It feels more like a display/visual preference than a primary user input, so the overall settings flow would probably feel more natural there.

Screenshot

Screenshot 2026-05-19 161211 Screenshot 2026-05-19 161233

@Charan-Mugada
Copy link
Copy Markdown
Contributor Author

@Aamod007 Thanks for the review and suggestions
I’ll update the PR description to match the template properly and optimize the current year calculation by moving it outside the loop.

I’ll also implement the optional UI polish improvements you suggested for better UX consistency.

@github-actions github-actions Bot added needs-details This PR is missing required description details. and removed needs-details This PR is missing required description details. labels May 19, 2026
@Charan-Mugada
Copy link
Copy Markdown
Contributor Author

@Aamod007, @JhaSourav07 Requested changes have been implemented

  • Optimized current year calculation by moving it outside the loop
  • Added (current) label for better UX consistency
  • Repositioned the Year selector below Theme Presets
  • Updated the PR description to properly follow the repository template

Please review again.

@JhaSourav07
Copy link
Copy Markdown
Owner

@Charan-Mugada

can you resolve conflicts?

@Charan-Mugada
Copy link
Copy Markdown
Contributor Author

@JhaSourav07 Conflicts resolved and branch updated.

If you like the implementation, please consider assigning another issue. I’d love to contribute more.

@JhaSourav07
Copy link
Copy Markdown
Owner

@Charan-Mugada

i am merging this right now from the next time i want you to keep the commits to one only

@JhaSourav07 JhaSourav07 merged commit 1be543b into JhaSourav07:main May 20, 2026
2 of 3 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Congratulations @Charan-Mugada! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. gssoc:approved PR has been reviewed and accepted for valid contribution points mentor:Aamod007 labels May 20, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ Feature: Add year filter to Customization Studio

3 participants