fix(api): improve speed parameter validation and bounds handling#208
Open
Shweta2117409 wants to merge 2 commits into
Open
fix(api): improve speed parameter validation and bounds handling#208Shweta2117409 wants to merge 2 commits into
Shweta2117409 wants to merge 2 commits into
Conversation
Contributor
|
@Shweta2117409 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Hey @Shweta2117409, welcome to CommitPulse! 🎉 Thanks for opening your first pull request — this is a big deal and we appreciate the effort! While you wait for a review, please double-check:
A maintainer will review your PR shortly. Hang tight! 🚀 |
Author
|
Implemented safer speed parameter validation with:
All lint, tests, and typechecks are passing. |
Author
|
Closing this duplicate PR and continuing work in #208. |
1 task
Author
|
All local checks, tests, linting, and production build are passing successfully. The remaining Vercel check appears to be deployment authorization-related for external contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #163
Improved
speedparameter validation by enforcing safe animation bounds and graceful fallback handling.Changes made
Added min/max bounds validation for
speedInvalid or extreme values now fallback to default
8sAdded tests covering:
Updated README parameter documentation for valid speed range
Pillar
Visual Preview
N/A (validation + test improvements only)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).README.mdif I added a new theme or URL parameter.