Skip to content

Cover remaining (incorrectly scheduled) calls#400

Merged
Jikoo merged 1 commit into
Jikoo:masterfrom
GemstoneGG:master
May 17, 2026
Merged

Cover remaining (incorrectly scheduled) calls#400
Jikoo merged 1 commit into
Jikoo:masterfrom
GemstoneGG:master

Conversation

@R00tB33rMan
Copy link
Copy Markdown

This resolves #399 by properly delegating open and close operations on the correct entity scheduler. Let me know if any other changes are needed/requested!

@Jikoo
Copy link
Copy Markdown
Owner

Jikoo commented May 17, 2026

I'm good with this, but the underlying problem is that the top inventory is backed by an item list which can be modified from the region of the owner and the region of any viewers. This just prevents the server from noticing that there is a problem because it doesn't know how our inventory's internals are handled.

I think the only way to get an actually safe short term fix would be to hack concurrency into the backing item list, but that's a lot more invasive than what OI currently does. I don't really want to be injecting replacement modified server classes, but I think with how locked down reflective access to final members is that would be the only possible course of action short of rewriting the inventory system to add an extra sync layer.

@Jikoo Jikoo enabled auto-merge (squash) May 17, 2026 13:09
@Jikoo Jikoo merged commit 98d819c into Jikoo:master May 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improper threading on Folia

2 participants